Samuel Pitoiset
a3835964ce
radv: only configure the CMASK tiling for TC-compat on GFX8
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9415 >
2021-03-17 08:55:15 +00:00
Samuel Pitoiset
b9222cc906
radv: make sure FMASK is enabled for TC-compat CMASK
...
Otherwise it makes no sense at all.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9415 >
2021-03-17 08:55:15 +00:00
Samuel Pitoiset
0c281283d8
radv: remove redundant check when enabling TC-compat CMASK
...
We already check that the image has CMASK.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9415 >
2021-03-17 08:55:15 +00:00
Samuel Pitoiset
d173ed2e9c
radv: do not enable TC-compat CMASK if the image isn't readable by a shader
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9415 >
2021-03-17 08:55:15 +00:00
Samuel Pitoiset
fb648634b0
radv: use common entrypoints for VK_KHR_copy_commands2
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9600 >
2021-03-17 07:43:36 +00:00
Iago Toral Quiroga
f29de817eb
compiler/glsl: call util_cpu_detect from glsl_type_singleton_init_or_ref
...
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Closes : #4393
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9457 >
2021-03-17 08:15:36 +01:00
Iago Toral Quiroga
1e4abf1fe3
vulkan/util: call glsl_type_singleton_init_or_ref from vk_instance_init
...
v2: link libvulkan_util with libglsl so it can find the glsl singleton symbols.
v3: link with libcompiler instead of libglsl (Jason)
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Reviewed-by: Dylan Baker <dylan.c.baker@intel.com >
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com > for the v3dv bits.
Reviewed-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com > for the turnip bits.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com > for the radv bits.
Acked-by: Dave Airlie <airlied@redhat.com > for the lvp bits.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9457 >
2021-03-17 08:15:36 +01:00
Lukas Feller
164a51c80f
v3dv: fix stride in buffer copy
...
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9402 >
2021-03-17 06:42:34 +00:00
Lukas Feller
99a11f25b2
v3dv: fix assertion in job_compute_frame_tiling
...
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9402 >
2021-03-17 06:42:34 +00:00
Timur Kristóf
d70e017c17
anv: Use ASSERTED for results that are only used in asserts.
...
This gets rid of unused variable warnings for these results.
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9634 >
2021-03-17 03:47:23 +00:00
Timur Kristóf
d7a94cae18
anv: Use unreachable() in anv_genX.
...
This gets rid of unused variable warnings on genX_thing, because
now the compiler will think that the unknown hardware generation
case is unreachable.
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9634 >
2021-03-17 03:47:23 +00:00
Timur Kristóf
17bc587f88
intel/compiler: Make room for maximum dest size in nir_emit_texture.
...
The maximum dest_size is 5, not 4.
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9634 >
2021-03-17 03:47:23 +00:00
Timur Kristóf
eb378e4cd0
intel/compiler: Use assume() instead of assert() for array bounds.
...
This should make both GCC and clang happy and make them believe that
the array bounds are not exceeded.
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9634 >
2021-03-17 03:47:23 +00:00
Daniel Stone
84f91dfea5
CI: Change LAVA job visibility
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9635 >
2021-03-17 01:50:37 +00:00
Mike Blumenkrantz
62d6ec083b
zink: enable PIPE_CAP_INVALIDATE_BUFFER
...
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9546 >
2021-03-17 01:40:55 +00:00
Mike Blumenkrantz
d5367cee09
zink: invalidate resources on map when discarding range
...
we can dump the whole vulkan object here for this case, which ends up being
much neater
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9546 >
2021-03-17 01:40:55 +00:00
Mike Blumenkrantz
cfa361e6cd
zink: handle streamout buffer rebinds
...
this really just means to nuke the counter buffer, and this can be done
by using a special bind_history bit that can be unset when the buffer has
been rebound
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9546 >
2021-03-17 01:40:55 +00:00
Mike Blumenkrantz
a00f10207c
zink: set valid region for streamout buffers on bind
...
this catches rebinds and is more accurate about the state of the region
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9546 >
2021-03-17 01:40:55 +00:00
Mike Blumenkrantz
8c1422dca5
zink: add a pipe_context::invalidate_resource hook
...
this creates new backing objects for the invalidated resource and, if
needed, rebinds it to any descriptor sets it might be used in by invalidating
the descriptor state and creating new view objects
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9546 >
2021-03-17 01:40:55 +00:00
Mike Blumenkrantz
d84c7c2a85
zink: remove direct samplerview batch-tracking
...
this moves tracking onto the surface/bufferview, which is more accurate
and allows the removal of a temporary hack in resource invalidation
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9546 >
2021-03-17 01:40:55 +00:00
Mike Blumenkrantz
2729513d29
zink: hook up resource bind history
...
seems like this should be a gallium thing with how many drivers copy/paste it
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9546 >
2021-03-17 01:40:55 +00:00
Mike Blumenkrantz
806c612131
ci/panfrost: disable the rest of these jobs temporarily
...
runners having a hard time right now
Acked-by: Daniel Stone <daniels@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9639 >
2021-03-17 01:34:49 +00:00
Mike Blumenkrantz
08d8aee222
zink: ci updates
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9624 >
2021-03-17 01:27:00 +00:00
Mike Blumenkrantz
2f3b09e422
zink: set ntv variable descriptor sets during compile phase
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9624 >
2021-03-17 01:27:00 +00:00
Mike Blumenkrantz
c1cdf30a11
zink: apply Delete All The Code methodology to the ubo/ssbo variables
...
gallium rewrites all the ubo/ssbo instructions to use the buffer index as
the instruction src. the nir variables which are passed to zink after that
point are completely worthless, and it's impossible to accurately determine
which one corresponds to which buffer
thus, deleting all the variables and creating new ones based on the buffers
that are used is the best option, and it also enables simplifying a ton
of code as well as doing even better improvements in the future
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9624 >
2021-03-17 01:27:00 +00:00
Mike Blumenkrantz
769c6dce23
zink: move zink_binding() to compiler.c
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9624 >
2021-03-17 01:27:00 +00:00
Mike Blumenkrantz
dbbcf4e780
zink: directly set nir variable bindings for reuse during ntv
...
this lets us prepopulate the binding values without "fetching" them
twice
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9624 >
2021-03-17 01:27:00 +00:00
Mike Blumenkrantz
84293f5395
zink: flatten binding numbers a bit
...
now that descriptor types are split, we can just use the type-max values
per stage as the increment instead of all type max values
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9624 >
2021-03-17 01:27:00 +00:00
Mike Blumenkrantz
eeb23b15eb
zink: break out sized uint array construction into util function
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9624 >
2021-03-17 01:27:00 +00:00
Mike Blumenkrantz
1950f8ec0c
zink: add ntv util function for checking if a glsl type is an atomic counter
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9624 >
2021-03-17 01:27:00 +00:00
Mike Blumenkrantz
90a1aaf956
zink: add debug info about missing atomic ops
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9624 >
2021-03-17 01:27:00 +00:00
Mike Blumenkrantz
5783298027
zink: add unsized array type to get_glsl_type_element() handling
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9624 >
2021-03-17 01:27:00 +00:00
Mike Blumenkrantz
6399906843
zink: also break out whole ntv bo struct pointer construction
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9624 >
2021-03-17 01:27:00 +00:00
Mike Blumenkrantz
99a87a283a
zink: break out bo array type construction into ntv util function
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9624 >
2021-03-17 01:27:00 +00:00
Mike Blumenkrantz
10bfe8759b
zink: use intermediate var for glsl non-array type during shader create
...
minor readability change
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9624 >
2021-03-17 01:27:00 +00:00
Mike Blumenkrantz
2b4609b66c
zink: run nir_convert_from_ssa last during compile
...
running this too early breaks other passes
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9624 >
2021-03-17 01:27:00 +00:00
Hyunjun Ko
d9fcf5de55
turnip: Enable nonuniform descriptor indexing
...
Signed-off-by: Hyunjun Ko <zzoon@igalia.com >
Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9125 >
2021-03-17 01:09:30 +00:00
Hyunjun Ko
e9fd2a2a58
ir3: Add nonuniform encodings to ir3 encoder and parser
...
By keeping track of nonuniform access from nir and storing it to ir3.
Signed-off-by: Hyunjun Ko <zzoon@igalia.com >
Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9125 >
2021-03-17 01:09:30 +00:00
Hyunjun Ko
433cdd1cff
ir3: fix has_src() to return correctly in ir3_nir_lower_tex_prefetch
...
This seems to be originally introduced from 2a0d45ae6c , and 562aaea07c
misused the method.
Fixes: 2a0d45ae6c "freedreno/ir3: Add a NIR pass to select tex instructions eligible for pre-fetch"
Fixes: 562aaea07c "freedreno/ir3: respect tex prefetch limits"
Signed-off-by: Hyunjun Ko <zzoon@igalia.com >
Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9125 >
2021-03-17 01:09:30 +00:00
Hyunjun Ko
d82b58c03e
nir: Set access at lower_ubo_vec4
...
Signed-off-by: Hyunjun Ko <zzoon@igalia.com >
Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9125 >
2021-03-17 01:09:30 +00:00
Hyunjun Ko
e0e55b181f
turnip: Return correct value of tu6_load_state_size
...
The state of active_desc_sets in pipeline should be set before
allocation of the pipeline so we get correct size of descriptor
sets and reserve enough space upfront.
Otherwise we might hit assert(pipeline->cs.bo_count == 1).
Signed-off-by: Hyunjun Ko <zzoon@igalia.com >
Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9125 >
2021-03-17 01:09:30 +00:00
Marek Olšák
fdbcb58c06
ac/llvm: handle demote in LLVM 13 that just added support for it
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9362 >
2021-03-17 00:42:27 +00:00
Timothy Arceri
08101aaaac
util/disk_cache: add cache item headers to single file cache entries
...
I mistakenly left these out of the original single file cache
implementation.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9443 >
2021-03-16 23:37:48 +00:00
Timothy Arceri
ba324bff1c
util/disk_cache: detangle cache item creation from disk writing
...
This refactors the cache code so that we create the full cache
item in memory before writing it to disk. The result is slightly
cleaner code and the ability to share this code between the single
and multi file cache implementations.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9443 >
2021-03-16 23:37:47 +00:00
Timothy Arceri
16b2b4342b
util/disk_cache: separate file reads from cache item validation
...
This will allow us to share validation between the single file cache
and the multifile cache.
It also reduces the number of malloc() calls.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9443 >
2021-03-16 23:37:47 +00:00
Timothy Arceri
9cf0aac130
util/compress: make compression function inputs const
...
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9443 >
2021-03-16 23:37:47 +00:00
Dave Airlie
a986d1ed63
lavapipe: add support for KHR_buffer_device_address.
...
Adds the missing magic lowering pass, and stores the pmem
pointer for easier returning to user.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9616 >
2021-03-16 23:05:10 +00:00
Dave Airlie
7b8d53afdd
lavapipe: only init immutable samplers for correct types.
...
This is ported from anv, and it needed to stop crashes with
the buffer_device_address CTS tests
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9616 >
2021-03-16 23:05:10 +00:00
Dave Airlie
c16f63b343
gallivm: convert packing to uint64 not double
...
Fixes some issues with later inttopotr casting.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9616 >
2021-03-16 23:05:10 +00:00
Danylo Piliaiev
e767208069
ir3: fix oob access to regs array for getbuf,getinfo,rgetinfo
...
Since they have zero source registers, src->regs[1] is out of bounds.
It probably wasn't able to cause any harm, but it's always better
be safe.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4209
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9609 >
2021-03-16 22:36:12 +00:00