AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
167,233 Commits 1 Branch 0 Tags
26208698ae02ebb35dc435be24f192d57ee5dc87
Commit Graph

11332 Commits

Author SHA1 Message Date
Marek Olšák 98eee7dee3 amd: replace SI_BIG_ENDIAN with UTIL_ARCH_BIG_ENDIAN 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>
 2023-02-24 21:27:24 +00:00
Marek Olšák e0c8b24e22 amd/registers: unify VRS combiner definition names between gfx103 and gfx11 
use gfx11 names

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>
 2023-02-24 21:27:24 +00:00
Marek Olšák 091268944d amd,radeonsi: remove unused LLVM functions 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>
 2023-02-24 21:27:24 +00:00
Marek Olšák 34c01cf718 amd: bump AMD_MAX_SE and change the CU mask type to 16 bits 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>
 2023-02-24 21:27:23 +00:00
Marek Olšák 63b21e3066 amd: add missing gfx11 register definitions 
Fixes: caa09f66ae - amd: add chip identification for gfx1100-1103

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>
 2023-02-24 21:27:23 +00:00
Marek Olšák ac0e83375a amd: fix LOD_BIAS on gfx6-9 and adjust the lod bias CAP 
Fixes: e673bb4ae4 - amd,util: fix how lod bias is converted to fixed-point

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>
 2023-02-24 21:27:23 +00:00
Marek Olšák fb70d8cf9c Revert "radeonsi/ci: Update stoney test expectations" 
This reverts commit 53cc509288.

This MR fixes it.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>
 2023-02-24 21:27:23 +00:00
Faith Ekstrand 96c832c47e spirv: Always emit deref_buffer_array_length intrinsics 
All the drivers have been converted to setting this option now except
imagination and they don't support SSBOs yet.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3993
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21446>
 2023-02-24 20:37:10 +00:00
Konstantin Seurer e2fa9ba9c6 radv: Use indirect header filling for compact builds 
Sets the accel struct size fields to the correct values which should
allow for more compaction.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20818>
 2023-02-24 15:14:40 +00:00
Konstantin Seurer 40e9efa2de radv/bvh: Add a shader for filling the header 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20818>
 2023-02-24 15:14:40 +00:00
Konstantin Seurer c83ea20683 radv/bvh: Move the size header field up 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20818>
 2023-02-24 15:14:40 +00:00
Konstantin Seurer b0fd43f1f7 radv: Move the geometry infos before the BVH 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20818>
 2023-02-24 15:14:40 +00:00
Konstantin Seurer 0800450cb9 radv: Use compact encoding 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20818>
 2023-02-24 15:14:40 +00:00
Konstantin Seurer 07c1b23022 radv/bvh: Implement compact encoding 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20818>
 2023-02-24 15:14:40 +00:00
Konstantin Seurer 71ccc8d600 radv: Add a build config for compact builds 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20818>
 2023-02-24 15:14:40 +00:00
Konstantin Seurer da4f498f6f radv/bvh/encoder: Move dst_node initialization into the loop 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20818>
 2023-02-24 15:14:40 +00:00
Konstantin Seurer 2792d012d2 radv/bvh/encode: Introduce is_root_node 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20818>
 2023-02-24 15:14:40 +00:00
Konstantin Seurer 2c0e158ae2 radv/bvh/encode: Move bvh_offset NULL check to the top of the loop 
NULL nodes don't have to be encoded and they also don't carry over any
information to their children.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20818>
 2023-02-24 15:14:40 +00:00
Konstantin Seurer 4e87a01b93 radv/bvh: Replace is_final_tree with bvh_offset 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20818>
 2023-02-24 15:14:40 +00:00
Konstantin Seurer 688f598237 radv/bvh/encode: Use the node type for identifying internal nodes 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20818>
 2023-02-24 15:14:40 +00:00
Samuel Pitoiset d2ff8b673a radv: advertise VK_EXT_image_sliced_view_of_3d on GFX10+ 
Pass dEQP-VK.pipeline.monolithic.sliced_view_of_3d_image.* on NAVI21.

Looks like older generations can't support it.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21359>
 2023-02-24 14:12:22 +00:00
Samuel Pitoiset 5520a40e05 radv: implement VK_EXT_image_sliced_view_of_3d on GFX10+ 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21359>
 2023-02-24 14:12:22 +00:00
Samuel Pitoiset e82c11df66 ac/nir: add resinfo lowering for sliced storage 3D views 
The first layer isn't necessarily 0 and depth shouldn't be minified.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21359>
 2023-02-24 14:12:22 +00:00
Bas Nieuwenhuizen ed76833705 radv: Implement & expose VK_EXT_pipeline_library_group_handles. 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21406>
 2023-02-23 22:17:30 +00:00
Bas Nieuwenhuizen d0f7587109 radv: Use group handles based on shader hashes. 
Should be stable.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21406>
 2023-02-23 22:17:30 +00:00
Bas Nieuwenhuizen 913de78731 radv: Use provided handles for switch cases in RT shaders. 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21406>
 2023-02-23 22:17:30 +00:00
Bas Nieuwenhuizen 430170702e radv: Hash group handles as part of RT pipeline key. 
So that we can start varying them  to avoid collisions while keeping
handles stable.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21406>
 2023-02-23 22:17:30 +00:00
Bas Nieuwenhuizen 9eb76ab638 radv: Add helper to hash stages. 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21406>
 2023-02-23 22:17:30 +00:00
Eric Engestrom fbd644c59d meson: replace vk_wsi_args with dependencies to let meson take care of transitivity 
Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19497>
 2023-02-23 09:42:46 +00:00
Rhys Perry 94abccf3ce aco: fix pathological case in LdsDirectVALUHazard 
Similar to bfd4ac4581.

No fossil-db changes.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Fixes: 296b4d95a3 ("aco/gfx11: workaround LdsDirectVALUHazard")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21423>
 2023-02-22 20:46:12 +00:00
Georg Lehmann ee47cc8256 amd,nir: remove byte_permute_amd intrinsic 
It's unused and if we ever want to use it again we should make it an alu
opcode instead.

Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21445>
 2023-02-22 20:13:52 +00:00
Samuel Pitoiset 7f2775bc8a radv/ci: cleanup CI lists for dEQP-VK.memory.* tests that timeout 
These tests usually take more than 30s to complete, so exclude them
completely instead. This should also make runs slightly faster.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21464>
 2023-02-22 13:25:13 +00:00
Konstantin Seurer 4d2a7ea146 radv: Use vk_acceleration_structure 
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21047>
 2023-02-22 11:58:57 +00:00
Samuel Pitoiset 1583b150d6 radv: set VS_OUT_MISC_SIDE_BUS_ENA for clip distances on GFX10.3+ 
On GFX10.3, all auxiliary position exports are optimized, so set it
for clip/cull distances. Both RadeonSI and llpc set it too.

Suggested by Marek.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21439>
 2023-02-22 07:17:33 +00:00
Konstantin Seurer af19762935 radv/rt: Skip instances after loading the entire node 
This avoids waiting for instance_data which can improve performance:

vk_ray_tracing_ao_KHR_app: 0.2% (The TLAS has 2 instances)
Quake II RTX: 1%
Control: 1%

We also have to shuffle around some code to avoid increasing VGPR usage.
That leaves us with the following stats:

Quake II RTX:
Totals from 7 (14.29% of 49) affected shaders:
CodeSize: 165612 -> 165716 (+0.06%)
Instrs: 31446 -> 31460 (+0.04%)
Latency: 596709 -> 554292 (-7.11%)
InvThroughput: 121998 -> 113327 (-7.11%)
VClause: 596 -> 587 (-1.51%)
Copies: 4664 -> 4646 (-0.39%)
PreVGPRs: 620 -> 639 (+3.06%)

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21421>
 2023-02-21 15:51:14 +00:00
Rhys Perry ab3184c0a2 aco: don't apply modifiers through DPP to unsupported instructions 
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21201>
 2023-02-21 14:59:38 +00:00
Georg Lehmann 3bd5b583f9 aco: combine a ^ ~b and ~(a ^ b) to v_xnor_b32 
Foz-DB Navi21:
Totals from 13 (0.01% of 134913) affected shaders:
CodeSize: 225432 -> 225180 (-0.11%)
Instrs: 41973 -> 41908 (-0.15%)
Latency: 297464 -> 297326 (-0.05%)
InvThroughput: 82536 -> 82467 (-0.08%)
Copies: 2452 -> 2440 (-0.49%)

Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21410>
 2023-02-21 13:35:31 +00:00
Daniel Schürmann 2bb369dd8d nir: add assertions that loops don't have a Continue Construct 
Hoping that I didn't miss any, this *should* add assertions
to all functions and passes which explicitly handle 'nir_loop'.

Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13962>
 2023-02-21 10:41:11 +00:00
Samuel Pitoiset ad459054ed radv: enable SQTT tracing on GFX11 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20338>
 2023-02-21 07:28:49 +00:00
Samuel Pitoiset dfa9b5d624 radv: disable SPM counters with RGP on GFX11 
They are likely different and perfcounters aren't defined on GFX11 yet.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20338>
 2023-02-21 07:28:49 +00:00
Samuel Pitoiset 5fe48baad6 radv: implement a workaround for SQTT on GFX11 
Found in AMDVLK, see the comment below for an explanation.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20338>
 2023-02-21 07:28:49 +00:00
Samuel Pitoiset 826ae89ba6 radv: make sure to wait for the trace buffer also on GFX11 
Otherwise, we might get incomplete data.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20338>
 2023-02-21 07:28:49 +00:00
Samuel Pitoiset c2bc4aff54 radv: only enable SQTT for SE0 on GFX11 
For weird reasons, the hardware doesn't return any data for other SEs.
RadeonSI is also affected by the same issue, enable only SE0 for now.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20338>
 2023-02-21 07:28:49 +00:00
Samuel Pitoiset ad4ad2ba84 radv: configure SQ_THREAD_TRACE_CTRL.REG_AT_HWM on GFX11 
AMDVLK sets this to 2 when the always stall mode is enabled, which is
the default in RADV.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20338>
 2023-02-21 07:28:49 +00:00
Samuel Pitoiset 15f1478eb9 radv/ci: move CI lists for external GPUs in separate folder 
A bunch of CI lists are maintained by ourselves with GPUs outside of
Mesa CI. Move them to a separate folder to avoid confusion.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21417>
 2023-02-20 13:05:50 +00:00
Samuel Pitoiset f334704078 radv/ci: disable vkcts-kabini-valve 
It's no longer reachable.

Suggested-by: Martin Roukala <martin.roukala@mupuf.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21417>
 2023-02-20 13:05:50 +00:00
Timur Kristóf 2c40215ab9 aco/optimizer: Change v_cmp with subgroup invocation to constant. 
When a shader has a comparison with the subgroup invocation id,
we can use a constant instead, saving a VALU instruction.
When the constant can't be represented as a 64-bit literal,
use the s_bfm_b64 instruction to generate it instead, which
is still a win.

Fossil DB stats on GFX11:
Totals from 300 (0.22% of 134913) affected shaders:
CodeSize: 2223052 -> 2214336 (-0.39%); split: -0.43%, +0.04%
Instrs: 430216 -> 429882 (-0.08%); split: -0.14%, +0.06%
Latency: 5881180 -> 5878181 (-0.05%); split: -0.05%, +0.00%
InvThroughput: 731846 -> 729293 (-0.35%)
Copies: 31662 -> 31847 (+0.58%); split: -0.03%, +0.61%
Branches: 8241 -> 8100 (-1.71%)
PreVGPRs: 15788 -> 15786 (-0.01%)

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20843>
 2023-02-18 21:16:58 +01:00
Chia-I Wu 4459668b6e radv: add a size check in radv_create_buffer for Android 
This is to make dEQP-VK.api.buffer.basic.size_max_uint64 pass on
android.

The test creates a buffer of size UINT64_MAX and makes sure the memory
requirement for the buffer is sane.  It fails because our memory
requirement is "align64(UINT64_MAX, 16)" which is 0 after overflow.

The test checks maintenance4's maxBufferSize and is skipped normally.
But the extension can be disabled on an android build.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21346>
 2023-02-17 18:14:34 +00:00
Timur Kristóf e13074d763 radv: Call nir_lower_array_deref_of_vec in radv_lower_io_to_scalar_early. 
This fixes an issue when a vector component of an arrayed output has a deref.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8197
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21028>
 2023-02-17 17:47:47 +00:00
Konstantin Seurer c76060c253 radv: Advertise ray query support with LLVM 
What could go wrong?

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21268>
 2023-02-17 17:04:47 +00:00