59cc628c06
radv: use radv_max_descriptor_set_size() for Vulkan 1.2 properties
...
Instead of copying this limit entirely.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19598 >
2022-11-09 15:16:01 +00:00
560b327696
radv/ci: add more subtests to VanGogh's flakes list
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19591 >
2022-11-09 12:18:04 +00:00
35d0d30a0e
radv/rra: Fix node type validation
...
Silly mistake...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19584 >
2022-11-09 09:16:15 +00:00
a9ab53fbe2
radv: stop emulating number of generated primitives by GS on GFX11
...
According to RadeonSI, only GFX10 and GFX10.3 need to emulate.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19319 >
2022-11-08 16:15:16 +00:00
bff6a38ed9
radv: advertise extendedDynamicState3ColorWriteMask
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19589 >
2022-11-08 11:04:54 +00:00
a92d1d13c5
radv: add support for dynamic color write mask
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19589 >
2022-11-08 11:04:54 +00:00
af868fcaad
radv/ci: add another test to the navi21 flakes list
...
Add dEQP-VK.memory.pipeline_barrier.host_read_host_write.1048576 to
the list of flakes of navi21. Found after 80 runs.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19569 >
2022-11-07 15:31:13 +00:00
505290dc44
ac/nir,radv: rework and fix NGG queries enables for VS/TES
...
XFB queries need to be enabled with NGG streamout and VS/TES.
Previously, the NGG lowering code relied on has_prim_query for XFB.
This fixes failures with RADV_PERFTEST=ngg_streamout on GFX10.3 with
the vkd3d-proton testsuite. Vulkan CTS is missing TES tests with XFB
queries apparently.
Cc: 22.3 mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19493 >
2022-11-07 14:54:53 +00:00
e4de5580bd
radv: move computing the binning state to the cmdbuf
...
With dynamic color write mask and rasterization samples, the binning
state will have to be re-computed dynamically. This shouldn't hurt
anything right now because it's only done at pipeline bind time.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19164 >
2022-11-07 14:22:02 +00:00
a5151dc46a
radv: always set FLUSH_ON_BINNING_TRANSITION
...
The hardware can detect binning transitions apparently, so it can be
hardcoded. This matches RadeonSI and PAL.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19164 >
2022-11-07 14:22:02 +00:00
5e9d7a1640
radv: cleanup setting disabled binning state for GFX9
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19164 >
2022-11-07 14:22:02 +00:00
04b557da39
radv: remove unused blend parameter to radv_pipeline_init_binning_state()
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19164 >
2022-11-07 14:22:02 +00:00
33d60bda9d
radv: re-emit the guardband state when restoring meta operations
...
Meta operations change dynamic states like viewports and previously,
the guardband state was also always re-emitted because it relied on
dynamic viewport/scissor changes.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7577
Fixes: 40d8df7280samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19521 >
2022-11-07 13:42:51 +00:00
0bf06400be
radv: consider allocated command buffers in the initial state.
...
The Vulkan spec says:
"When a command buffer is allocated, it is in the initial state.
Some commands are able to reset a command buffer (or a set of
command buffers) back to this state from any of the executable,
recording or invalid state. Command buffers in the initial state
can only be moved to the recording state, or freed."
Because the status wasn't initialized, it was implicitly set to
RADV_CMD_BUFFER_STATUS_INVALID and that triggered a reset for newly
allocated command buffers.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19506 >
2022-11-07 12:02:36 +01:00
c1c7adbcbd
radv/ci: use wildcards for the query_pool.statistics_query flakes on VG
...
I got yet another new failure in VanGogh, and rather than playing the
game of wack a mole, let's be a little less picky and just use these
wildcards:
- dEQP-VK.query_pool.statistics_query.geometry_shader_primitives.*
- dEQP-VK.query_pool.statistics_query.host_query_reset.geometry_shader_primitives.*
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19541 >
2022-11-07 10:01:52 +00:00
8b66c0ac76
amd: add cosmetic gfx10 and gfx11 changes
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19477 >
2022-11-06 18:16:48 -05:00
9cc58f0f49
ac/surface/tests: add more gfx103 and gfx11 tests
...
This might start timing out in the CI.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19477 >
2022-11-06 18:16:48 -05:00
24e8a6f17c
ac/llvm: don't use the mbcnt workaround for LLVM 16 and set range metadata
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19477 >
2022-11-06 18:16:48 -05:00
8956682810
amd: rename enums ARCTURUS -> MI100, ALDEBARAN -> MI200
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19477 >
2022-11-06 17:20:39 -05:00
bdfacd0a24
radeonsi/gfx11: fix compute scratch buffer - WAVES is always per SE
...
Fixes: ba02ed91a6pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19477 >
2022-11-06 17:10:35 -05:00
c37357f4e0
radv/rra: Remove some node type validation
...
Node types can only be invalid for certain acceleration structure types.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19544 >
2022-11-06 17:03:52 +00:00
868107e16c
radv/rra: Improve validation message formatting
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19544 >
2022-11-06 17:03:52 +00:00
07bf85c2ec
radv/rra: Rename rra_accel_struct_validation_fail
...
...to rra_validation_fail since it is used quite often.
Shortening the name should improve readability.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19544 >
2022-11-06 17:03:52 +00:00
e5b3efe582
radv/rt: Restore prev barycentrics when rejecting hits
...
Closes : #6348
cc: mesa-stable
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19534 >
2022-11-06 11:36:10 +00:00
9a8453d07e
radv: Use compares for node type in traversal.
...
The HW has no bit test instruction, so we change 3 pairs of and+cmp
to a single and + 3 cmps, saving 2 VALU instructions.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19454 >
2022-11-05 16:38:48 +00:00
06adf6ad11
radv: invalidate L2 instead of only writeback L2 when using DCC stores
...
It seems INV_L2 is the right thing to do, especially for RDNA2 chips
with non-coherent RBs (NAVI22 is one of these). This fixes DCC
corruption.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6476
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7507
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19516 >
2022-11-04 22:40:11 +00:00
26c8fedc1b
radv: make the GDS/GDS OA buffer objects resident
...
GDS is used for NGG queries/streamout (GFX10+ only) and the BOs were
only added to the graphics queue because compute doesn't need them.
Though, the kernel emits a GDS switch when a queue submission doesn't
use GDS. That means that submitting jobs on the compute queue without
GDS can reset the state of the graphics queue and lead to GPU hangs.
The only viable solution for now is to make the GDS BOs resident to
avoid resetting the state between queues. This shouldn't introduce
more syncs between queues because GDS BOs are similar for both.
This fixes a GPU hang with Warhammer Chaosbane during loading time and
possibly some spurious random GPU hangs. Note that this GPU hang was
workarounded on the Steam side with RADV_DEBUG=nongg.
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19466 >
2022-11-04 21:52:35 +00:00
7c5c181694
ci: Uprev kernel to 6.0
...
And also enable some kconfigs needed by existing Qualcomm-based
Chromebooks and also a new model: kingoftown.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19069 >
2022-11-04 14:51:24 +00:00
67cee534a8
CI: convert to use the new S3 server instead of the legacy minio
...
We don't need to login anymore, but we can't use plain minio commands
now. `ci-fairy` got a helper as `s3cp` to keep an almost identical
API.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19076 >
2022-11-04 11:41:42 +00:00
e891e84f4b
radv: fix setting MIN_LOD for texture descriptors on GFX11
...
Found by inspection because the MIN_LOD bits were moved.
Cc: 22.3 mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19496 >
2022-11-04 06:43:04 +00:00
ca29d9a67c
ac: fix IB parsing for Stoney
...
We need to pass the family to register parsing functions.
Reviewed-by: Mihai Preda <mhpreda@gmail.com >
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19419 >
2022-11-04 00:42:08 +00:00
a54c8cdaf2
ac/gpu_info: simplify how has_accelerated_dot_product is set
...
Reviewed-by: Mihai Preda <mhpreda@gmail.com >
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19419 >
2022-11-04 00:42:08 +00:00
a338a2da58
amd/registers: regenerate gfx11 headers from amd-staging-drm-next
...
Reviewed-by: Mihai Preda <mhpreda@gmail.com >
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19419 >
2022-11-04 00:42:08 +00:00
b361ecc0da
amd/registers: describe allowed register ranges better
...
Reviewed-by: Mihai Preda <mhpreda@gmail.com >
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19419 >
2022-11-04 00:42:08 +00:00
ff4cd2133d
amd/registers: fix parse_kernel_headers.py warnings by adding missing enums
...
Reviewed-by: Mihai Preda <mhpreda@gmail.com >
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19419 >
2022-11-04 00:42:07 +00:00
c4104482c8
ac/llvm: remove unnecessary gfx11 condition for nir_intrinsic_store_buffer_amd
...
ac_build_buffer_store_dword is responsible for this.
Reviewed-by: Mihai Preda <mhpreda@gmail.com >
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19419 >
2022-11-04 00:42:07 +00:00
95ed033066
radv: Use spirv1.5 instead of vulkan1.2
...
Ubuntu 20.04 ships a glslangValidator that doesn't know about vulkan1.2 yet.
Fixes: 27186537https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19479 >
2022-11-03 22:58:47 +00:00
6da2320a92
radv/rra: Print invalid node types
...
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Reviewed-by: Friedrich Vock <friedrich.vock@gmx.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19465 >
2022-11-03 21:25:04 +00:00
dd908e87d0
radv/ci: document a recent regression on VanGogh
...
It seems like !19442 may have been introducing a lot of flakes in the
dEQP-VK.query_pool.statistics_query.* tests.
Samuel is looking into it right now, but let's document the flakes in
the mean time so that we can get back to a green baseline.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Acked-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19470 >
2022-11-03 12:01:26 +00:00
751eb1ba06
radv/ci: document a flake on VanGogh
...
Seen only once, so not really worth filing a bug for.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Acked-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19470 >
2022-11-03 12:01:26 +00:00
a7ad99f0ae
radv/ci: document some VanGogh flakes that came from splitting the job
...
These tests are also flaky on NAVI21, which were also introduced when
the job was split in two.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Acked-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19470 >
2022-11-03 12:01:26 +00:00
fab87b0f41
radv: fix fallback for extreme geometry with tessellation on GFX11
...
It would assert anyways. Found by inspection.
Cc: 22.3 mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19495 >
2022-11-03 11:27:53 +00:00
d876ddc920
radv: Make the compute scratch waves per SE as well.
...
Fixes: 278e533ec9https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19488 >
2022-11-03 10:03:44 +00:00
b8865ad046
radv: Fix compute scratch buffer emission.
...
Copied wrong from radeonsi. The registers following the scratch
buffer address are the shader rsrc1/rsrc2. Not the user SGPR0
containing the ring resource word 1.
Fixes: 278e533ec9https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19488 >
2022-11-03 10:03:44 +00:00
32cf10e17a
radv: Style cleanup.
...
Now have a local info ptr.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19488 >
2022-11-03 10:03:44 +00:00
e2ac43ddad
ac/nir: create gs copy shader with scalar outputs
...
radeonsi assume IO has been scalarized, this simplify the code
and radeonsi implementation.
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Signed-off-by: Qiang Yu <yuq825@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19455 >
2022-11-03 01:17:18 +00:00
0004974467
radeonsi: increase gfx1100/gfx1101 physical vgprs
...
https://reviews.llvm.org/D134522
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18825 >
2022-11-02 17:09:32 +00:00
50073d6135
aco/gfx11: increase gfx1100/gfx1101 physical vgprs
...
https://reviews.llvm.org/D134522
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18825 >
2022-11-02 17:09:32 +00:00
67ebe86f0c
ac/gpu_info: increase gfx1100/gfx1101 physical vgprs
...
https://reviews.llvm.org/D134522
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18825 >
2022-11-02 17:09:32 +00:00
254f4fa573
radv: increase gfx1100/gfx1101 physical vgprs
...
https://reviews.llvm.org/D134522
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18825 >
2022-11-02 17:09:32 +00:00
Samuel Pitoiset