AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
201,327 Commits 1 Branch 0 Tags
09b5de379cd47a025662459d03aed970da170676
Commit Graph

201327 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Alyssa Rosenzweig 2600224f77 agx: clarify scratch size units 
bytes, not words.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:11 +00:00
Alyssa Rosenzweig d21bc62f4d agx: fix =spill 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:11 +00:00
Alyssa Rosenzweig 4e3a5f0e60 agx: fix spilling in i686 builds 
../src/asahi/compiler/agx_pack.c: In function ‘agx_pack_instr’:
../src/asahi/compiler/agx_pack.c:1074:38: warning: left shift count >= width of type [-Wshift-count-overflow]
 1074 |          ((uint64_t)q4 << 42) | (1UL << 47) | // XXX
      |                                      ^~
../src/asahi/compiler/agx_pack.c:1110:43: warning: left shift count >= width of type [-Wshift-count-overflow]
 1110 |          ((uint64_t)i5 << 44) | (L ? (1UL << 47) : 0) |
      |                                           ^~
../src/asahi/compiler/agx_pack.c:1131:64: warning: left shift count >= width of type [-Wshift-count-overflow]
 1131 |          ((uint64_t)((I->stack_size >> 4) & 0xF) << 32) | (1UL << 47) | // XXX

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:11 +00:00
Alyssa Rosenzweig 8f9cf43828 asahi/virtio: fix allocate-with-alignment 
fixes crashes when spilling inside the microVM:

../src/asahi/lib/agx_scratch.c:176: void agx_scratch_realloc(struct agx_scratch *): Assertion `!(blocks_gpu & (block_size_bytes - 1))' failed

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:11 +00:00
Alyssa Rosenzweig e0cda48a90 asahi/virtio: fix ptr cats 
../src/asahi/lib/decode.c:933:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  933 |       (void *)c->vertex_attachments;
      |       ^
../src/asahi/lib/decode.c:941:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  941 |       (void *)c->fragment_attachments;

etc

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:11 +00:00
Alyssa Rosenzweig 9bd3a854e6 asahi/decode: fix ptr casts 
../src/asahi/lib/decode.c:933:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  933 |       (void *)c->vertex_attachments;
      |       ^
../src/asahi/lib/decode.c:941:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  941 |       (void *)c->fragment_attachments;

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:11 +00:00
Alyssa Rosenzweig 88a0da6b7c asahi: identify factor buffer size 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:11 +00:00
Alyssa Rosenzweig bbad4454bf asahi: fix UB affecting x86 builds 
dEQP-VK.robustness.image_robustness.bind.notemplate.r32f.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_1.2d_array.comp

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:11 +00:00
Alyssa Rosenzweig 673f56fcb1 libagx: drop unused arg 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:11 +00:00
Alyssa Rosenzweig 8d95f584da libagx: simplify tcs out calc 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig 9cfffc5e86 libagx: cleanup loop vars 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Asahi Lina 01ef3152c9 agx: Fix implicit sync for virtgpu 
The asahi kernel driver is a pure-explicit-sync driver and userspace is
required to handle implicit sync itself, by importing/exporting fences
in shared dma-bufs. Mesa handles this in its own native or guest
context, but dma-buf fences are not shared between the guest and the
host, so this breaks implicit sync across the VM boundary.

To make this work, explicitly pass a resource list to the host so it can
perform the implicit sync dance, like we do in agx_batch.c. This
essentially turns the virtgpu protocol into an implicit sync protocol
(like many other legacy GPU drivers), which makes sense here since we
don't particularly have the primitives to pass through and manage "host"
syncobjs that we'd need to do it at that level.

Signed-off-by: Asahi Lina <lina@asahilina.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig 6f3c1c909b hk: don't leak GS subparts in an error path 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig 568f0a81c6 hk: don't leak GS rast with rast disc 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig 2dbd6c440f hk: don't leak NIR with VS/GS 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig 332a97cc34 hk: free large_bos 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig cd66a6813b agx: plumb COHERENT 
set the magic caching bits. this fixes memory model fails on g13d.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig d4e34bc829 agx: pull out the big hammers for device-barriers 
g13d.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig f67db39aef hk: lower memory model 
we don't know how to flush caches on g13d and we don't want to try either.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig 0ac160e1c4 hk: ban compression with feedback loops 
affects dEQP-VK.pipeline.monolithic.attachment_feedback_loop_layout.sampler.sampled_image.image_type.2d.format.d16_unorm_depth_read_write_different_areas

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig 2f2effcb7e hk: fix attachmentless multisampling tile sizes 
fixes dEQP-VK.pipeline.monolithic.framebuffer_attachment.no_attachments_ms on
g14c. it's unclear to me how this passed on g13g, though.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig 2f0935459f asahi: add tib sample setter helper 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig f3a407344d hk: quiet gcc warning 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig 57aabdb159 hk: drop bad comment 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig a830037638 hk: drop some dead code 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig 3e8b8fadb0 hk: switch to vk_meta for buffer copies 
no reason not to.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig 6604fc8d88 hk: advertise modifiers 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig 52fcd0412a hk: disable mods on funny float formats 
Honeykrisp version of b78a691ce2 ("nil,nvk: Disable modifiers for
B10G11R11_UFLOAT and E5B9G9R9_UFLOAT").

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig 3a3a0c97f6 hk: handle compression modifiers 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig 4ddfc1cfdd ail: pull in DRM modifier helper 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Alyssa Rosenzweig b01d53d95a hk: add missing dep 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
 2024-10-05 18:30:10 +00:00
Georg Lehmann 07032102e9 aco: use s_pack_lh for bitfield_select(0xffff) 
Foz-DB Navi31
Totals from 13 (0.02% of 79206) affected shaders:
Instrs: 44871 -> 44838 (-0.07%)
CodeSize: 223804 -> 223608 (-0.09%)
Latency: 220186 -> 220191 (+0.00%); split: -0.01%, +0.02%
InvThroughput: 54169 -> 54186 (+0.03%); split: -0.00%, +0.03%
SALU: 5048 -> 5023 (-0.50%)

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31509>
 2024-10-05 17:55:08 +00:00
Georg Lehmann a6f82cf16d aco: use s_pack_hl for shfr16 
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31509>
 2024-10-05 17:55:08 +00:00
Sergi Blanch Torne 27dbaccb5c Revert "ci: disable Collabora's farm due to maintenance" 
This reverts commit 686459f115.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31530>
 2024-10-05 16:32:51 +00:00
Ganesh Belgur Ramachandra cc27e3ea29 amd: remove the redundant target library info instance in LLVM compiler 
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30506>
 2024-10-05 09:10:06 +00:00
Ganesh Belgur Ramachandra 0a352a838a amd,radeonsi: reduce legacy::PassManager use to only run backend passes 
The legacy::PassManager is only required to run backend optimizations
and for code generation. It should be deprecated when the new PM
can handle code generation on its own.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30506>
 2024-10-05 09:10:06 +00:00
Ganesh Belgur Ramachandra 38e50221cd amd,radeonsi: use new pass manager to handle midend optimizations 
Adds an optimizer structure that builds an optimization
pipeline to run LLVM passes using the new pass manager.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30506>
 2024-10-05 09:10:06 +00:00
Sergi Blanch Torne 686459f115 ci: disable Collabora's farm due to maintenance 
Planned downtime in the farm:
* Start: 2024-10-05 05:00 UTC
* End: 2024-10-05 19:00 UTC

Signed-off-by: Sergi Blanch Torne <sergi.blanch.torne@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31461>
 2024-10-05 04:16:54 +00:00
Carlos Santa 39e3015c36 intel/hang_replay: remove EXEC_OBJECT_WRITE 
This flag causes the following failure:

total_vma: 0x0000000071c9d000
fail to set context hw img: Invalid argument

Fixes: bab52763f4 ("intel/hang_replay: fix batch address")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11959
Signed-off-by: Carlos Santa <carlos.santa@intel.corp-partner.google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31494>
 2024-10-04 21:37:41 +00:00
Carlos Santa 700141da43 intel/hang_replay: fix the typo in the ioctl call 
What we really want to pass is DRM_IOCTL_I915_GEM_CONTEXT_GETPARAM
vs DRM_IOCTL_I915_GEM_CONTEXT_SETPARAM

Fixes: a9f1151de2 ("intel/hang_replay: use hw image param")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11959
Signed-off-by: Carlos Santa <carlos.santa@intel.corp-partner.google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31494>
 2024-10-04 21:37:41 +00:00
Alyssa Rosenzweig 5fe3f57d3f vulkan: export vk_robustness_disabled 
HK will use this for a HK_PERFTEST=norobust flag.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31466>
 2024-10-04 17:52:10 +00:00
Alyssa Rosenzweig 1a2827e401 vulkan: merge driver internal bits 
no reason for hk and vk_meta to diverge here.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31466>
 2024-10-04 17:52:10 +00:00
Alyssa Rosenzweig 07470d19dd zink: fix buffer view clamp overflow 
dEQP-GLES3.functional.texture.specification.teximage2d_pbo.rgba32ui_cube
asserting on hkz

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31306>
 2024-10-04 17:11:52 +00:00
Alyssa Rosenzweig f7d45cb362 tu/virtio: silence startup spam on asahi 
quiet a big pile of:

TU: error: ../src/freedreno/vulkan/tu_knl_drm_virtio.cc:1299: could not get connect vdrm: No such file or directory (VK_ERROR_INCOMPATIBLE_DRIVER)

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31243>
 2024-10-04 16:30:17 +00:00
Alyssa Rosenzweig 78a202157e virtio/vdrm: don't spam 
number of log splat would be proportional to # of enabled vdrm drivers
otherwise. silences a pile of

   MESA: info: wrong context_type: 2

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31243>
 2024-10-04 16:30:17 +00:00
Samuel Pitoiset 0503975363 radv: fix image view descriptors for samplers on GFX6-8 
On GFX6-8, there are some cases where the view must use mip0 and
minified image sizes. Otherwise, samplers use BASE_LEVEL=level and
image sizes.

Note that CB/DS surfaces use minified image sizes because the mip
level can't be set in registers.

This fixes an issue uncovered by c87ce78d10 ("ac/surface: enable
thick tiling for 3D textures for better perf on gfx6-8"). But it
also fixes a bunch of Zink failures specific to GFX6-8.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11112
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31363>
 2024-10-04 14:59:31 +00:00
Samuel Pitoiset 0ac5e3c9b1 radv: update image view extent for non-compressed views earlier on GFX10+ 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31363>
 2024-10-04 14:59:31 +00:00
Karmjit Mahil 581c99b30c ir3: Use foreach_instr_safe in ir3_shared_folding 
When processing the last instruction prior to the block terminator,
ir3_shader_folding can append a new instruction prior to the
terminator, so the `current_instruction->next == new_instruciton`
instead of `current_instruction->next == terminator` which leads
to the assert in `foreach_instr` being hit, so use
`foreach_instr_safe`.

Signed-off-by: Karmjit Mahil <karmjit.mahil@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31478>
 2024-10-04 13:49:57 +00:00
Mike Blumenkrantz 5ba00df1f9 anv: add VK_FORMAT_G10X6_B10X6R10X6_2PLANE_420_UNORM_3PACK16 to modifier exceptions 
this is implemented

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31516>
 2024-10-04 13:22:08 +00:00
Sergi Blanch Torne 6c94c24978 ci: Disable gk20a-gles 
This job may have some issue with its FDO_HTTP_CACHE_URI to download the
artifacts from S3.

Signed-off-by: Sergi Blanch Torne <sergi.blanch.torne@collabora.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11973
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31522>
 2024-10-04 12:52:58 +00:00