1129537e4c
util: Move pipe_semaphore to u_thread.h and rename it to util_semaphore
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19557 >
2022-11-08 05:21:42 +00:00
cf44028c02
util: Move UTIL_MAX_CPUS from u_thread.h to u_cpu_detect.h
...
UTIL_MAX_CPUS is not used by u_thread.* anymore after commit
"util: replace UTIL_MAX_CPUS by util_cpu_caps.num_cpu_mask_bits"
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19266 >
2022-10-25 11:06:05 +00:00
64ee9c1158
util: Merge duplicated function prototype in u_thread.h that named with util_barrier*
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19266 >
2022-10-25 11:06:05 +00:00
17d46893fd
util: Remove non used UTIL_MAX_L3_CACHES in u_thread.h
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19266 >
2022-10-25 11:06:05 +00:00
53ab57e888
util: Move the function implementation from u_thread.h to u_thread.c
...
Move the platform dependent functions from u_thread.h to u_thread.c,
so that avoid pull unneeded headers when using u_thread.h, including the big windows.h
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18425 >
2022-10-20 03:04:56 +00:00
399dc71a30
c11: Getting the macro guard of HAVE_PTHREAD in c11/threads.h to be consistence with util/u_uthread.h
...
The macro guard of #if defined(_WIN32) && !defined(__CYGWIN__) is comes from yohhoy's implementation
and that's not consistence with util/u_uthread.h, this caused it's hard to understand.
Now we change the behavior that's always rely on how meson detecting HAVE_PTHREAD.
So we always disable detecting of threads on Win32 as it's always included in the kernel32 library to
avoid detecting pthreads in mingw.
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18425 >
2022-10-20 03:04:56 +00:00
54beddb5d2
util: Remove the guard WIN32_WINNT >= 0x0600 in u_thread.h
...
We already require Windows Vista or later before this commit;
No need check WIN32_WINNT >= 0x0600
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18425 >
2022-10-20 03:04:56 +00:00
b6e4aa6f31
meson/mesa/wide: define WIN32_LEAN_AND_MEAN with pre_args
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18425 >
2022-10-20 03:04:56 +00:00
0edf63de76
Try to fix FTBFS on kfreebsd architecture
...
Fixes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4081
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15058 >
2022-09-22 10:30:36 +02:00
dc7a61aa17
util: Implement util_thread_get_time_nano on win32
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18001 >
2022-08-12 15:05:47 +00:00
e7b4af434b
c11: Implement and use of thrd_current properly on win32
...
Now thrd_t are a struct that contains both thread handle and thread id.
For threads that not created by thrd_create, thrd_current are returning pseudo thread handle;
but we can still compare threads differences by using thread id.
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17071 >
2022-08-10 20:14:15 +00:00
365253605a
util: Remove usage of USE_ELF_TLS in u_thread.h
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17213 >
2022-07-29 23:59:12 +00:00
73c51b5c57
util: thread_local doesn't support to be exported on OSX
...
The linkage error is:
Undefined symbols for architecture x86_64:
"thread-local wrapper routine for _glapi_tls_Context", referenced from:
__mesa_GetActiveUniform_impl in libmesa.a(main_uniform_query.cpp.o)
Fixes: a9e2c699aahttps://gitlab.freedesktop.org/mesa/mesa/-/issues/6756
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Acked-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17784 >
2022-07-29 12:57:26 +00:00
6f0aba42ad
util: Don't block SIGSEGV for new threads
...
SIGSEGV is used by Vulkan API trace layers to track user changes in
device memory mapped to user space. Now with drivers such as Zink, GLES
applications are translated into Vulkan API calls and therefore it is
possible to be tracked by Vulkan api trace layers.
Blocking SIGSEGV hinders one of the memory tracking mechanisms used by
such layers.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Adam Jackson <ajax@redhat.com >
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17273 >
2022-07-13 06:51:27 +00:00
a9e2c699aa
util/c11: Update function u_thread_create to be c11 conformance
...
Do not assume thrd_t to be a pointer or integer, as the C11 standard tells us:
thrd_t: implementation-defined complete object type identifying a thread
At https://en.cppreference.com/w/c/thread
So we always return the thread creation return code instead of thrd_t value, and judge the return
code properly.
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15087 >
2022-06-15 17:37:17 +00:00
6e33ef2bb9
c11: Implement thread_local in c11/threads.h
...
Use thread_local when possible
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15087 >
2022-06-15 17:37:17 +00:00
b7773fd105
util: Define WIN32_LEAN_AND_MEAN before include of windows.h in u_thread.h
...
This is a prepare for move the c11 threads implementation into c source code
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15087 >
2022-06-15 17:37:17 +00:00
c91e3c6a42
util: Should not use ASSERTED in util_thread_get_time_nano
...
The parameter is not ASSERTED
Fixes: 0f1b3fc17fluoyonggang@gmail.com >
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15655 >
2022-03-29 23:33:21 +00:00
0f1b3fc17f
util: Fixes unused parameter warnings
...
The compiler warning:
```
../src/mesa/util/u_thread.h: In function 'util_thread_get_time_nano':
../src/mesa/util/u_thread.h:239:34: warning: unused parameter 'thread' [-Wunused-parameter]
239 | util_thread_get_time_nano(thrd_t thread)
| ~~~~~~~^~~~~~
```
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15553 >
2022-03-24 21:56:48 +00:00
d9c3601e29
util: trim trailing space for files src/util/**/*
...
Using the following bash script doing that
```
cd src/util
find . -type f -print0 | xargs -0 -n1 sed -i 's/[ \t]*$//'
```
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15093 >
2022-03-21 17:57:15 +00:00
8570a2a280
Use initial-exec TLS for glibc only, enable TLS elsewhere
...
It is not portable to use initial-exec TLS in dlopened libraries. glibc
and FreeBSD allocate extra memory for extra initial-exec variables
specifically for libGL, but other libcs including musl do not.
Keep initial-exec disabled on FreeBSD since it is apparently broken for
some reason:
https://gitlab.freedesktop.org/mesa/mesa/-/issues/966#note_394512
https://github.com/jbeich/mesa/commit/81dbdb15d55054242eded0eb2f32621d583c1aaf
Enable TLS on OpenBSD and Haiku based on the u_thread.h comment that
emutls is better than pthread_getspecific, which seems plausible given
that emutls has strictly more information to work with.
Fixes #966 .
Acked-by: Tapani Pälli <tapani.palli@intel.com >
Acked-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12722 >
2021-11-20 11:56:34 -05:00
04c90f292e
util/queue: fix a data race detected by TSAN when finishing the queue
...
Thread sanitizer complains if it detects that the pthread_barrier
is destroyed when a thread might still blocked on the barrier.
Fix this by destroying the barrier only if pthread_barrier_wait
returns PTHREAD_BARRIER_SERIAL_THREAD which is the value for success.
In practice this shouldn't fix anything serious given that this code
is only called when the disk cache is destroyed.
Original patch from Timothy Arceri.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4342
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13861 >
2021-11-19 09:02:23 +01:00
a923e95b10
util: Zero out all of mask in util_set_thread_affinity
...
memset operates in bytes, and there are 8-bits in a byte. This is a
very easy to miss typo. :(
Fixes: 9758b1d416marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11228 >
2021-06-15 20:01:52 +00:00
0d8e431871
android: Fix ELF TLS support.
...
Android 29 introduced general-dynamic TLS variable support ("quick
function call to look up the location of the dynamically allocated
storage"), while Mesa on normal Linux has used initial-exec ("use some of
the startup-time fixed slots, hope for the best!"). Both would be better
options than falling all the way back to pthread_getspecific(), which is
the alternative we have pre-29.
Reviewed-by: Roman Stratiienko <r.stratiienko@gmail.com >
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10389 >
2021-06-02 03:10:49 +00:00
75a9cb1033
util: Add a helper macro for defining initial-exec variables.
...
I'm going to add another case for Android shortly, and then we can keep
the logic all in one spot.
Reviewed-by: Roman Stratiienko <r.stratiienko@gmail.com >
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10389 >
2021-06-02 03:10:49 +00:00
62014aeccd
util/u_thread: fix u_thread_setname for long names
...
"WSI swapchain queue", set by vulkan/wsi/x11, is longer than 15
characters.
Signed-off-by: Chia-I Wu <olvaffe@gmail.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10935 >
2021-05-25 16:39:02 +00:00
d2a920ee6e
util: Extract thread-id helpers from u_current
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9323 >
2021-03-11 04:42:15 +00:00
0b910cc019
util/u_thread: Disable pthread_barrier_t on Haiku
...
* Causes a lockup on SMP systems
Reviewed-by: Alexander von Gluck IV <kallisti5@unixzen.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8323 >
2021-01-09 20:51:39 -06:00
5195a30d27
util: fix -Wshift-count-overflow warning
...
Reviewed-by: Jose Fonseca <jfonseca@vmware.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7392 >
2020-11-17 21:23:20 +00:00
d8ea509965
util: completely rewrite and do AMD Zen L3 cache pinning correctly
...
This queries the CPU cache topology correctly.
Acked-by: Jose Fonseca <jfonseca@vmware.com >
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7054 >
2020-10-30 05:07:57 +00:00
4f2c2307f9
util: add util_get_current_cpu using sched_getcpu and Windows equivalent
...
Acked-by: Jose Fonseca <jfonseca@vmware.com >
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7054 >
2020-10-30 05:07:57 +00:00
9758b1d416
util: add util_set_thread_affinity helpers including Windows support
...
Acked-by: Jose Fonseca <jfonseca@vmware.com >
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7054 >
2020-10-30 05:07:57 +00:00
96d9f7761d
util: consolidate thread_get_time functions
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Acked-by: Jose Fonseca <jfonseca@vmware.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7054 >
2020-10-30 05:07:57 +00:00
53a15925da
util: remove unused util_get_L3_for_pinned_thread
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Acked-by: Jose Fonseca <jfonseca@vmware.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7054 >
2020-10-30 05:07:57 +00:00
55765f80b9
util/u_thread: include pthread_np.h if found
...
Required for pthread_set_name_np() on OpenBSD as there is no
pthread_setaffinity_np() to define PTHREAD_SETAFFINITY_IN_NP_HEADER.
Fixes: dcf9d91a80jsg@jsg.id.au >
Reviewed-by: Eric Engestrom <eric@engestrom.ch >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5630 >
2020-08-31 09:14:57 +00:00
29e2a3b8f5
gallium,util: undef ALIGN on FreeBSD to prevent name clash
...
Some rare headers like ipc/shm and pthread_np cause
machine/param.h to be included which defines a macro called ALIGN.
Signed-off-by: Matt Turner <mattst88@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3559 >
2020-07-01 16:47:05 +00:00
4f52425159
util: Do not fail to build on unknown pthread_setname_np
...
This is only used for debugging, so better making porting on various systems
less hard.
Reviewed-by: Matt Turner <mattst88@gmail.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3229 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3229 >
2020-01-22 22:39:57 +00:00
eb40c0adfc
util/u_thread: Fix build under Haiku
2020-01-22 16:21:54 +00:00
9661fc9cdb
util/u_thread: Restrict u_thread_get_time_nano on macOS.
...
macOS does not have pthread_getcpuclockid.
src/util/u_thread.h:156:4: error: implicit declaration of function 'pthread_getcpuclockid' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
pthread_getcpuclockid(thread, &cid);
^
Fixes: 4913215d14https://gitlab.freedesktop.org/mesa/mesa/issues/2171
Signed-off-by: Vinson Lee <vlee@freedesktop.org >
Acked-by: Eric Engestrom <eric@engestrom.ch >
2019-12-10 21:35:47 -08:00
4913215d14
util/u_thread: don't restrict u_thread_get_time_nano() to __linux__
...
pthread_getcpuclockid() and clock_gettime() are also available on at least
OpenBSD, FreeBSD, NetBSD, DragonFly, Cygwin.
Signed-off-by: Jonathan Gray <jsg@jsg.id.au >
Signed-off-by: Marek Olšák <marek.olsak@amd.com >
2019-12-02 17:23:49 -05:00
7040795a69
util: Solaris has linux-style pthread_setname_np
...
Fixes: dcf9d91aalan.coopersmith@oracle.com >
Acked-by: Eric Engestrom <eric.engestrom@intel.com >
2019-10-16 13:45:57 +01:00
0141b7c6b2
util: Cygwin has linux-style pthread_setname_np
...
Fixes: dcf9d91a
2019-08-09 12:46:43 +00:00
0233372581
util: fix cpuset support on FreeBSD
...
Reviewed-by: Eric Engestrom <eric.engestrom@intel.com >
2019-08-08 21:44:33 +01:00
2fd30e3722
util: fix pointer type on NetBSD
...
NetBSD expects a `void *` argument [1] as the printf-style arguments to
the formatting string, so we need to cast the `const` away.
[1] https://netbsd.gw.com/cgi-bin/man-cgi?pthread_setname_np++NetBSD-current
Suggested-by: Kamil Rytarowski <n54@gmx.com >
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-08-03 00:20:21 +00:00
dcf9d91a80
util: Handle differences in pthread_setname_np
...
There are a lot of unfortunate differences in the implementation of this
function. NetBSD and Mac OS X in particular require different arguments.
https://stackoverflow.com/questions/2369738/how-to-set-the-name-of-a-thread-in-linux-pthreads/7989973#7989973
provides for a good overview of the differences.
Fixes: 9c411e020dhttps://bugs.freedesktop.org/show_bug.cgi?id=111264
Reviewed-by: Eric Engestrom <eric.engestrom@intel.com >
[Eric: use DETECT_OS_* instead of PIPE_OS_*]
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-08-02 18:38:52 +01:00
9c411e020d
util: Drop preprocessor guards for glibc-2.12
...
glibc-2.12 was released in 2010. No one is building new Mesa against 9
year old glibc, and removing these checks allows the code to work on
other C libraries like musl.
Acked-by: Eric Engestrom <eric.engestrom@intel.com >
2019-07-30 11:49:09 -07:00
1fd79b4b6d
util: Don't block SIGSYS for new threads
...
SIGSYS is needed for programs using seccomp for sandboxing.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
2019-02-26 19:39:14 +01:00
3acc18fcf7
move pthread_setaffinity_np check to the build system
...
Rather than trying to encode all of the rules in a header, lets just put
them in the build system where they belong. This fixes the build on
FreeBSD, which does have pthraed_setaffinity_np, but it's in a
pthread_np.h, not behind _GNU_SOURCE. FreeBSD also implements cpu_set
slightly differently, so additional changes would be required to get it
working right there anyway.
v2: - fix #define in autotools
Fixes: 9f1bbbdbbdemil.velikov@collabora.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Eric Engestrom <eric.engestrom@intel.com >
2018-09-17 13:16:46 -07:00
9f1bbbdbbd
util: try to fix the Android and MacOS build
...
Bionic does not have pthread_setaffinity_np.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107869
Reviewed-by: Jose Fonseca <jfonseca@vmware.com >
Reviewed-by: Tapani Pälli <tapani.palli@intel.com >
2018-09-10 14:49:07 -04:00
8d473f555a
st/mesa: pin driver threads to a specific L3 cache on AMD Zen (v2)
...
v2: use set_context_param
Reviewed-by: Brian Paul <brianp@vmware.com >
2018-09-07 16:03:30 -04:00
Yonggang Luo