From fe680844f54279e7313cd48564ebc7bfadeb5083 Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Tue, 14 Jan 2025 16:54:39 +0100 Subject: [PATCH] panfrost: fix overflow-debugging We were using an unsigned instead of a size_t for the size calculation, which would break large allocations. So let's switch to size_t here, for good measure. Reviewed-by: Boris Brezillon Reviewed-by: Eric R. Smith Part-of: --- src/gallium/drivers/panfrost/pan_mempool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_mempool.c b/src/gallium/drivers/panfrost/pan_mempool.c index 31b638cf710..6c6deb58d10 100644 --- a/src/gallium/drivers/panfrost/pan_mempool.c +++ b/src/gallium/drivers/panfrost/pan_mempool.c @@ -144,8 +144,8 @@ panfrost_pool_alloc_aligned(struct panfrost_pool *pool, size_t sz, !(pool->create_flags & PAN_BO_INVISIBLE)) { long page_size = sysconf(_SC_PAGESIZE); assert(page_size > 0 && util_is_power_of_two_nonzero(page_size)); - unsigned aligned = ALIGN_POT(sz, page_size); - unsigned bo_size = aligned + PAN_GUARD_SIZE; + size_t aligned = ALIGN_POT(sz, page_size); + size_t bo_size = aligned + PAN_GUARD_SIZE; bo = panfrost_pool_alloc_backing(pool, bo_size); if (!bo)