From fe283032bf1116291142577e48abcf2c2e2600fd Mon Sep 17 00:00:00 2001 From: SoroushIMG Date: Mon, 15 May 2023 12:09:47 +0100 Subject: [PATCH] pvr: remove unnecessary asserts "Soft" renderpass start clears are already handled in pvr_clear_attachments_render_init. The other assert is completely unnecessary and the case of undefined usage is in fact valid. It means the depth has been partially cleared. Signed-off-by: SoroushIMG Acked-by: Erik Faye-Lund Part-of: --- src/imagination/vulkan/pvr_cmd_buffer.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/imagination/vulkan/pvr_cmd_buffer.c b/src/imagination/vulkan/pvr_cmd_buffer.c index 9778eabd20e..ed8cc7f9fd9 100644 --- a/src/imagination/vulkan/pvr_cmd_buffer.c +++ b/src/imagination/vulkan/pvr_cmd_buffer.c @@ -1621,8 +1621,6 @@ static VkResult pvr_sub_cmd_gfx_job_init(const struct pvr_device_info *dev_info, d_load = true; } else if (hw_render->depth_init == VK_ATTACHMENT_LOAD_OP_LOAD) { enum pvr_depth_stencil_usage depth_usage = sub_cmd->depth_usage; - - assert(depth_usage != PVR_DEPTH_STENCIL_USAGE_UNDEFINED); d_load = (depth_usage != PVR_DEPTH_STENCIL_USAGE_NEVER); } else { d_load = sub_cmd->barrier_load; @@ -1648,8 +1646,6 @@ static VkResult pvr_sub_cmd_gfx_job_init(const struct pvr_device_info *dev_info, } else if (hw_render->stencil_init == VK_ATTACHMENT_LOAD_OP_LOAD) { enum pvr_depth_stencil_usage stencil_usage = sub_cmd->stencil_usage; - - assert(stencil_usage != PVR_DEPTH_STENCIL_USAGE_UNDEFINED); s_load = (stencil_usage != PVR_DEPTH_STENCIL_USAGE_NEVER); } else { s_load = sub_cmd->barrier_load; @@ -2945,9 +2941,6 @@ pvr_perform_start_of_render_clears(struct pvr_cmd_buffer *cmd_buffer) true, &ds_index_list); } - - if (index_list_clear_mask) - pvr_finishme("Add support for generating loadops shaders!"); } static void pvr_stash_depth_format(struct pvr_cmd_buffer_state *state,