From fcb229cbe07073686bfce1ca87ce1983f74d049d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Pi=C3=B1eiro?= Date: Wed, 10 Feb 2021 12:38:35 +0100 Subject: [PATCH] v3dv/device: clarify that we can't expose textureCompressionBC From spec: "textureCompressionBC specifies whether all of the BC compressed texture formats are supported. If this feature is enabled" Note the *all*. v3d hw supports BC1, BC2, and BC3, but not BC4 through BC7. Let's clarify that we can't expose textureCompressionBC even if we support some of them. Reviewed-by: Iago Toral Quiroga Part-of: --- src/broadcom/vulkan/v3dv_device.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/broadcom/vulkan/v3dv_device.c b/src/broadcom/vulkan/v3dv_device.c index c3cee0fc4d0..cf76716a6d8 100644 --- a/src/broadcom/vulkan/v3dv_device.c +++ b/src/broadcom/vulkan/v3dv_device.c @@ -857,6 +857,10 @@ v3dv_GetPhysicalDeviceFeatures(VkPhysicalDevice physicalDevice, .samplerAnisotropy = true, .textureCompressionETC2 = true, .textureCompressionASTC_LDR = false, + /* Note that textureCompressionBC requires that the driver support all + * the BC formats. V3D 4.2 only support the BC1-3, so we can't claim + * that we support it. + */ .textureCompressionBC = false, .occlusionQueryPrecise = true, .pipelineStatisticsQuery = false,