From f7c74e35eef06b6b6f5b14eff4a129fb9592e562 Mon Sep 17 00:00:00 2001 From: Lucas Stach Date: Fri, 14 Jul 2023 19:01:51 +0200 Subject: [PATCH] etnaviv: remove bogus comment about replacing resource storage While we might want to employ this orphaning trick one day to avoid stalls on busy resources it's certainly not as easy as the comment implies, as this would involve changing all relocs in cached state objects referencing the resource. Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner Part-of: --- src/gallium/drivers/etnaviv/etnaviv_transfer.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_transfer.c b/src/gallium/drivers/etnaviv/etnaviv_transfer.c index 6aa2b9a71d6..696e74ec418 100644 --- a/src/gallium/drivers/etnaviv/etnaviv_transfer.c +++ b/src/gallium/drivers/etnaviv/etnaviv_transfer.c @@ -108,13 +108,6 @@ etna_transfer_unmap(struct pipe_context *pctx, struct pipe_transfer *ptrans) struct etna_resource *rsc = etna_resource(ptrans->resource); struct etna_resource_level *res_level = &rsc->levels[ptrans->level]; - /* XXX - * When writing to a resource that is already in use, replace the resource - * with a completely new buffer - * and free the old one using a fenced free. - * The most tricky case to implement will be: tiled or supertiled surface, - * partial write, target not aligned to 4/64. */ - if (rsc->texture && !etna_resource_newer(rsc, etna_resource(rsc->texture))) rsc = etna_resource(rsc->texture); /* switch to using the texture resource */