From f79697123e763a802be09f3a866843619d808f4a Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Tue, 7 Feb 2023 10:31:54 -0500 Subject: [PATCH] panfrost: Remove stale TODO While the text here is still nominally accurate, we should be seeing so few shader variants at this point that the locking contention isn't a big deal. Signed-off-by: Alyssa Rosenzweig Reviewed-by: Boris Brezillon Part-of: --- src/gallium/drivers/panfrost/pan_shader.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_shader.c b/src/gallium/drivers/panfrost/pan_shader.c index 3117747cb99..8b3a52dcec8 100644 --- a/src/gallium/drivers/panfrost/pan_shader.c +++ b/src/gallium/drivers/panfrost/pan_shader.c @@ -319,9 +319,6 @@ panfrost_update_shader_variant(struct panfrost_context *ctx, ctx->prog[type] = compiled; - /* TODO: it would be more efficient to release the lock before - * compiling instead of after, but that can race if thread A compiles a - * variant while thread B searches for that same variant */ simple_mtx_unlock(&uncompiled->lock); }