From f5841c343b44709cc8820b00e2fd411153a34931 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Wed, 14 Oct 2020 17:20:14 -0700 Subject: [PATCH] v3dv: Fix assert using assign instead of compare. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix defect reported by Coverity Scan. Assign instead of compare (PW.ASSIGN_WHERE_COMPARE_MEANT) assign_where_compare_meant: use of "=" where "==" may have been intended Fixes: ca86c7c65a82 ("v3dv: assert command buffers are executable when submitting to a queue") Signed-off-by: Vinson Lee Reviewed-by: Alejandro Piñeiro Reviewed-by: Iago Toral Quiroga Part-of: --- src/broadcom/vulkan/v3dv_queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/broadcom/vulkan/v3dv_queue.c b/src/broadcom/vulkan/v3dv_queue.c index 14ae1297266..0899e748ce6 100644 --- a/src/broadcom/vulkan/v3dv_queue.c +++ b/src/broadcom/vulkan/v3dv_queue.c @@ -834,7 +834,7 @@ queue_submit_cmd_buffer(struct v3dv_queue *queue, pthread_t *wait_thread) { assert(cmd_buffer); - assert(cmd_buffer->status = V3DV_CMD_BUFFER_STATUS_EXECUTABLE); + assert(cmd_buffer->status == V3DV_CMD_BUFFER_STATUS_EXECUTABLE); if (list_is_empty(&cmd_buffer->jobs)) return queue_submit_noop_job(queue, pSubmit);