From f367cdad0ae9c2ba68d0491d21681e361f591abc Mon Sep 17 00:00:00 2001 From: Christoph Pillmayer Date: Mon, 20 Oct 2025 10:55:29 +0000 Subject: [PATCH] pan: Fix bi_load_tl dst arg name bi_load_tl's dst arg was named src, this was confusing. Reviewed-by: Lars-Ivar Hesselberg Simonsen Reviewed-by: Eric R. Smith Part-of: --- src/panfrost/compiler/bi_ra.c | 6 +++--- src/panfrost/compiler/compiler.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/panfrost/compiler/bi_ra.c b/src/panfrost/compiler/bi_ra.c index 99054d6350b..e0f207d8b01 100644 --- a/src/panfrost/compiler/bi_ra.c +++ b/src/panfrost/compiler/bi_ra.c @@ -686,14 +686,14 @@ bi_tls_ptr(bool hi) } bi_instr * -bi_load_tl(bi_builder *b, unsigned bits, bi_index src, unsigned offset) +bi_load_tl(bi_builder *b, unsigned bits, bi_index dst, unsigned offset) { if (b->shader->arch >= 9) { assert(offset < 0x8000); /* valhall has 16 bit signed offset */ - return bi_load_to(b, bits, src, bi_tls_ptr(false), bi_tls_ptr(true), + return bi_load_to(b, bits, dst, bi_tls_ptr(false), bi_tls_ptr(true), BI_SEG_TL, offset); } else { - return bi_load_to(b, bits, src, bi_imm_u32(offset), bi_zero(), BI_SEG_TL, + return bi_load_to(b, bits, dst, bi_imm_u32(offset), bi_zero(), BI_SEG_TL, 0); } } diff --git a/src/panfrost/compiler/compiler.h b/src/panfrost/compiler/compiler.h index 63e3b5ab3d9..16435c0c246 100644 --- a/src/panfrost/compiler/compiler.h +++ b/src/panfrost/compiler/compiler.h @@ -1666,7 +1666,7 @@ bi_init_builder(bi_context *ctx, bi_cursor cursor) } /* insert load/store for spills */ -bi_instr *bi_load_tl(bi_builder *b, unsigned bits, bi_index src, unsigned offset); +bi_instr *bi_load_tl(bi_builder *b, unsigned bits, bi_index dst, unsigned offset); void bi_store_tl(bi_builder *b, unsigned bits, bi_index src, unsigned offset); /* Insert an instruction at the cursor and move the cursor */