From f1e4d5c910c9ecf68831b9244ad4184516234de1 Mon Sep 17 00:00:00 2001 From: Lionel Landwerlin Date: Thu, 2 Mar 2023 14:39:31 +0200 Subject: [PATCH] anv: fix scratch buffer reloc in 3DSTATE_HS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We need to have the scratch buffer added to the pipeline BO tracking list, so it's added to the batch buffer and finally to the execbuffer list. Otherwise we pagefault (or read the default scratch page on i915). Fixes dEQP-VK.subgroups.ballot_broadcast.graphics.subgroupbroadcast_u16vec4 on CI (and probably other tests). Signed-off-by: Lionel Landwerlin Fixes: 2028f1caa385 ("anv: emit 3DSTATE_HS in cmd_buffer_flush_gfx_state") Reviewed-by: Tapani Pälli Part-of: --- src/intel/vulkan/genX_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index f51004f8904..05a4260cbe7 100644 --- a/src/intel/vulkan/genX_pipeline.c +++ b/src/intel/vulkan/genX_pipeline.c @@ -1293,7 +1293,7 @@ emit_3dstate_hs_ds(struct anv_graphics_pipeline *pipeline, hs.DispatchMode = tcs_prog_data->base.dispatch_mode; hs.IncludePrimitiveID = tcs_prog_data->include_primitive_id; - GENX(3DSTATE_HS_pack)(NULL, pipeline->gfx8.hs, &hs); + GENX(3DSTATE_HS_pack)(&pipeline->base.batch, pipeline->gfx8.hs, &hs); anv_batch_emit(&pipeline->base.batch, GENX(3DSTATE_DS), ds) { ds.Enable = true;