From f065c2f0ac9ab7563f828484294c73092cf4d3b2 Mon Sep 17 00:00:00 2001 From: Eric Engestrom Date: Mon, 21 Jul 2025 16:07:29 +0200 Subject: [PATCH] ci: fix rustfmt job rules Specifically, fe8bc3f23e3bc01ff7af made the "default" case `manual` instead of `never`, which is causing all staging pipelines to have that job regardless of any file `changes`, and always `manual` making it block pipelines. Let's make it automatic for upstream pipelines (ie. staging and push-to-main), and only run on file `changes`. Fixes: fe8bc3f23e3bc01ff7af ("ci: Only run rustfmt when necessary") Part-of: --- .gitlab-ci/test-source-dep.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitlab-ci/test-source-dep.yml b/.gitlab-ci/test-source-dep.yml index 342a85cde5c..89a6f0e8f0c 100644 --- a/.gitlab-ci/test-source-dep.yml +++ b/.gitlab-ci/test-source-dep.yml @@ -228,6 +228,9 @@ - if: *is-merge-request when: never # non-pre-merge: run but only advisory + - if: $CI_PROJECT_NAMESPACE == "mesa" + changes: *rustfmt_files + allow_failure: true - when: manual allow_failure: true