From ed759ad7952df07c07d48de5ed45b16dce06e8b0 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Mon, 5 Jun 2023 23:22:07 -0700 Subject: [PATCH] dzn: Fix qpool->queries_lock double lock Fix defect reported by Coverity Scan. Double lock (LOCK) double_lock: mtx_lock locks qpool->queries_lock while it is locked. Fixes: a012b219640 ("microsoft: Initial vulkan-on-12 driver") Signed-off-by: Vinson Lee Part-of: --- src/microsoft/vulkan/dzn_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/microsoft/vulkan/dzn_query.c b/src/microsoft/vulkan/dzn_query.c index b080174e7b1..be49e54f83e 100644 --- a/src/microsoft/vulkan/dzn_query.c +++ b/src/microsoft/vulkan/dzn_query.c @@ -240,7 +240,7 @@ dzn_ResetQueryPool(VkDevice device, query->fence = NULL; } } - mtx_lock(&qpool->queries_lock); + mtx_unlock(&qpool->queries_lock); memset((uint8_t *)qpool->collect_map + dzn_query_pool_get_result_offset(qpool, firstQuery), 0, queryCount * qpool->query_size);