From e9190c45d59695f64daf82a7ded0179851cfc397 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Wed, 15 Jun 2022 15:56:24 -0400 Subject: [PATCH] panfrost: Disable QUADS on Valhall Even with the fixes in the rest of the series, arb-provoking-vertex-render is still failing on Valhall for a single subcase (involving QUADS). It seems likely that QUADS support is broken on Valhall, given it's not used in any of the APIs for which Arm ships drivers. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/gallium/drivers/panfrost/pan_screen.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/panfrost/pan_screen.c b/src/gallium/drivers/panfrost/pan_screen.c index 72698843c8e..b7cc255645c 100644 --- a/src/gallium/drivers/panfrost/pan_screen.c +++ b/src/gallium/drivers/panfrost/pan_screen.c @@ -325,6 +325,14 @@ panfrost_get_param(struct pipe_screen *screen, enum pipe_cap param) modes |= BITFIELD_BIT(PIPE_PRIM_POLYGON); } + if (dev->arch >= 9) { + /* Although Valhall is supposed to support quads, they + * don't seem to work correctly. Disable to fix + * arb-provoking-vertex-render. + */ + modes &= ~BITFIELD_BIT(PIPE_PRIM_QUADS); + } + return modes; }