From e5d70d303fbcc5010e12d3247355717ab9ce5288 Mon Sep 17 00:00:00 2001 From: Faith Ekstrand Date: Mon, 13 Nov 2023 12:01:59 -0600 Subject: [PATCH] nak: Drop the SM50 encoding of BREV We should add an OpBfe instead of this mess. Part-of: --- src/nouveau/compiler/nak/encode_sm50.rs | 35 ------------------------- 1 file changed, 35 deletions(-) diff --git a/src/nouveau/compiler/nak/encode_sm50.rs b/src/nouveau/compiler/nak/encode_sm50.rs index c119137d143..2b71ee8d502 100644 --- a/src/nouveau/compiler/nak/encode_sm50.rs +++ b/src/nouveau/compiler/nak/encode_sm50.rs @@ -1536,40 +1536,6 @@ impl SM50Instr { self.set_field(40..41, not_mod) } - fn encode_brev(&mut self, op: &OpBrev) { - assert!(op.src.is_reg_or_zero()); - - // BREV doesn't exist on SM50, but we have BFE.BREV. - let src_modifier = Some(ALUSrcsModifier { - src0_opt: None, - src1_opt: None, - src2_opt: None, - }); - let encoding_info = ALUEncodingInfo { - opcode: 0x00, - encoding_type: ALUEncodingType::Variant4, - reg_modifier: src_modifier, - imm24_modifier: src_modifier, - cbuf_modifier: src_modifier, - imm32_behavior_opt: None, - }; - - self.encode_alu( - encoding_info, - Some(op.dst), - ALUSrc::from_src(&op.src), - ALUSrc::Imm32(0x2000), - ALUSrc::None, - ); - - /* - * 0: U32 - * 1: S32 - */ - self.set_bit(48, false); - self.set_bit(40, true); /* BREV */ - } - fn encode_fadd(&mut self, op: &OpFAdd) { let ftz = false; /* TODO: FTZ */ let dnz = false; /* TODO: DNZ */ @@ -1969,7 +1935,6 @@ impl SM50Instr { Op::SuSt(op) => si.encode_sust(&op), Op::S2R(op) => si.encode_s2r(&op), Op::PopC(op) => si.encode_popc(&op), - Op::Brev(op) => si.encode_brev(&op), Op::Prmt(op) => si.encode_prmt(&op), Op::Ld(op) => si.encode_ld(&op), Op::St(op) => si.encode_st(&op),