From e4b524709f90d81895e990065966f930c087d252 Mon Sep 17 00:00:00 2001 From: Yiwei Zhang Date: Wed, 24 Sep 2025 06:54:20 +0000 Subject: [PATCH] panvk: fix image/buffer destroy to use MODE_IMMEDIATE for unmap The TYPE_UNMAP was falsely passed as mode, and got mapped to MODE_ASYNC. This change fixes that. Fixes: 86068ad1eee ("panvk: implement sparse resources") Reviewed-by: Caterina Shablia Part-of: --- src/panfrost/vulkan/panvk_buffer.c | 4 ++-- src/panfrost/vulkan/panvk_image.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/panfrost/vulkan/panvk_buffer.c b/src/panfrost/vulkan/panvk_buffer.c index ed5d7570a1e..8d84d1ff27d 100644 --- a/src/panfrost/vulkan/panvk_buffer.c +++ b/src/panfrost/vulkan/panvk_buffer.c @@ -169,8 +169,8 @@ panvk_DestroyBuffer(VkDevice _device, VkBuffer _buffer, .size = va_range, }, }; - ASSERTED int ret = - pan_kmod_vm_bind(device->kmod.vm, PAN_KMOD_VM_OP_TYPE_UNMAP, &unmap, 1); + ASSERTED int ret = pan_kmod_vm_bind( + device->kmod.vm, PAN_KMOD_VM_OP_MODE_IMMEDIATE, &unmap, 1); assert(!ret); panvk_as_free(device, buffer->vk.device_address, va_range); diff --git a/src/panfrost/vulkan/panvk_image.c b/src/panfrost/vulkan/panvk_image.c index 5bd885484fb..ae419ae4c59 100644 --- a/src/panfrost/vulkan/panvk_image.c +++ b/src/panfrost/vulkan/panvk_image.c @@ -677,8 +677,8 @@ panvk_DestroyImage(VkDevice _device, VkImage _image, .size = va_range, }, }; - ASSERTED int ret = - pan_kmod_vm_bind(device->kmod.vm, PAN_KMOD_VM_OP_TYPE_UNMAP, &unmap, 1); + ASSERTED int ret = pan_kmod_vm_bind( + device->kmod.vm, PAN_KMOD_VM_OP_MODE_IMMEDIATE, &unmap, 1); assert(!ret); panvk_as_free(device, image->sparse.device_address, va_range);