From e4b170a72062e0648ca87a847975717600c20e6b Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Mon, 26 Oct 2020 13:00:07 +0100 Subject: [PATCH] v3dv: enable the logicOp feature MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For us this is mostly handled in the compiler by a NIR lowering so for the Vulkan driver we only need to make sure that we program our shader key correctly from the pipeline state, which we were already doing. It doesn't look like CTS has any coverage for this yet so it has only been smoke tested, but it seems to be working correctly, as expected. Reviewed-by: Alejandro Piñeiro Part-of: --- src/broadcom/vulkan/v3dv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/broadcom/vulkan/v3dv_device.c b/src/broadcom/vulkan/v3dv_device.c index 6e0eefb031d..501c042c167 100644 --- a/src/broadcom/vulkan/v3dv_device.c +++ b/src/broadcom/vulkan/v3dv_device.c @@ -676,7 +676,7 @@ v3dv_GetPhysicalDeviceFeatures(VkPhysicalDevice physicalDevice, .tessellationShader = false, .sampleRateShading = true, .dualSrcBlend = false, - .logicOp = false, + .logicOp = true, .multiDrawIndirect = false, .drawIndirectFirstInstance = false, .depthClamp = false,