From e34e474f24bc0047cc0b30597781f34365fd1f7b Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Thu, 23 Jan 2025 10:39:07 +0100 Subject: [PATCH] panvk: do not expose EXT_subgroup_size_control on bifrost This exptension requires Vulkan 1.1, which we don't expose there yet. While we're at it, put panvk into the normal sorted order of the list of drivers. Fixes: d46b80249bd ("panvk: enable subgroupSizeControl") Reviewed-by: Boris Brezillon Part-of: --- docs/features.txt | 2 +- src/panfrost/vulkan/panvk_physical_device.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index 3cbe1328bbd..fa79e5f251e 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -502,7 +502,7 @@ Vulkan 1.3 -- all DONE: anv, lvp, nvk, radv, tu, vn, v3dv VK_EXT_private_data DONE (anv, hasvk, lvp, nvk, panvk, pvr, radv, tu, v3dv, vn) VK_EXT_image_robustness DONE (anv, hasvk, lvp, nvk, panvk, radv, tu, v3dv, vn) VK_EXT_shader_demote_to_helper_invocation DONE (anv, hasvk, lvp, nvk, radv, tu, v3dv, vn) - VK_EXT_subgroup_size_control DONE (anv, hasvk, lvp, nvk, radv, tu, v3dv, vn, panvk) + VK_EXT_subgroup_size_control DONE (anv, hasvk, lvp, nvk, panvk/v10+, radv, tu, v3dv, vn) VK_EXT_texel_buffer_alignment DONE (anv, hasvk, lvp, nvk, pvr, radv, tu, v3dv, vn) VK_EXT_texture_compression_astc_hdr DONE (vn) VK_EXT_tooling_info DONE (anv, hasvk, nvk, panvk, pvr, radv, tu, v3dv, vn) diff --git a/src/panfrost/vulkan/panvk_physical_device.c b/src/panfrost/vulkan/panvk_physical_device.c index f9bab2c3493..8124da9259f 100644 --- a/src/panfrost/vulkan/panvk_physical_device.c +++ b/src/panfrost/vulkan/panvk_physical_device.c @@ -245,7 +245,7 @@ get_device_extensions(const struct panvk_physical_device *device, .EXT_sampler_filter_minmax = arch >= 10, .EXT_scalar_block_layout = true, .EXT_shader_module_identifier = true, - .EXT_subgroup_size_control = true, + .EXT_subgroup_size_control = arch >= 10, /* requires vk1.1 */ .EXT_tooling_info = true, .GOOGLE_decorate_string = true, .GOOGLE_hlsl_functionality1 = true,