AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

aco: introduce Operand flag 'CopyKill'

Browse Source 
This flag indicates that the Operand must be copied in order to satisfy register
constraints. The copy is immediately killed by the instruction.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30299>
This commit is contained in:
Daniel Schürmann
2024-07-04 11:03:43 +02:00
committed by Marge Bot
parent 91f65d5935
commit dfc13fcf9f
2 changed files with 33 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/amd/compiler/aco_live_var_analysis.cpp
+17 -2
View File
@@ -42,7 +42,7 @@ get_temp_registers(Instruction* instr)
}
for (Operand op : instr->operands) {
if (op.isFirstKill()) {
if (op.isFirstKill() || op.isCopyKill()) {
demand_before += op.getTemp();
if (op.isLateKill())
demand_after += op.getTemp();
@@ -252,8 +252,12 @@ process_live_temps_per_block(live_ctx& ctx, Block* block)
Operand& operand = insn->operands[i];
if (!operand.isTemp())
continue;
const Temp temp = operand.getTemp();
if (operand.isFixed() && ctx.program->progress < CompilationProgress::after_ra) {
assert(!operand.isLateKill());
ctx.program->needs_vcc |= operand.physReg() == vcc;
/* Check if this operand gets overwritten by a precolored definition. */
if (std::any_of(insn->definitions.begin(), insn->definitions.end(),
[=](Definition def)
@@ -263,8 +267,19 @@ process_live_temps_per_block(live_ctx& ctx, Block* block)
operand.physReg() + operand.size() > def.physReg();
}))
operand.setClobbered(true);
/* Check if this temp is fixed to a different register as well.
* This assumes that operands of one instruction are not precolored twice to
* the same register. In this case, register pressure might be overestimated.
*/
for (unsigned j = i + 1; !operand.isCopyKill() && j < insn->operands.size(); ++j) {
if (insn->operands[j].isTemp() && insn->operands[j].getTemp() == temp &&
insn->operands[j].isFixed()) {
operand_demand += temp;
insn->operands[j].setCopyKill(true);
}
}
}
const Temp temp = operand.getTemp();
if (operand.isKill())
continue;