From de367eec074b1cb936dad377b3c0ea04b2517e45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tapani=20P=C3=A4lli?= Date: Fri, 14 Feb 2025 20:25:32 +0200 Subject: [PATCH] intel/dev: reduce warning noise from urb settings II MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In 4064b5546bb, the idea was to have the minimum value as if all stages are active, however hwconfig does not follow that for the tessellation control stage. Ignore min values from hwconfig. Fixes: 4064b5546bb ("intel/dev: reduce warning noise from urb settings"); Signed-off-by: Tapani Pälli Reviewed-by: Lionel Landwerlin Acked-by: Kenneth Graunke Part-of: --- src/intel/dev/intel_hwconfig.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/intel/dev/intel_hwconfig.c b/src/intel/dev/intel_hwconfig.c index 28fadbdeac6..2b2c6b3052e 100644 --- a/src/intel/dev/intel_hwconfig.c +++ b/src/intel/dev/intel_hwconfig.c @@ -260,33 +260,25 @@ process_hwconfig_item(struct intel_device_info *devinfo, case INTEL_HWCONFIG_MAX_COPY_CS: case INTEL_HWCONFIG_DEPRECATED_URB_SIZE_IN_KB: break; /* ignore */ - case INTEL_HWCONFIG_MIN_VS_URB_ENTRIES: - DEVINFO_HWCONFIG(200, urb.min_entries[MESA_SHADER_VERTEX], item); - break; case INTEL_HWCONFIG_MAX_VS_URB_ENTRIES: DEVINFO_HWCONFIG(200, urb.max_entries[MESA_SHADER_VERTEX], item); break; case INTEL_HWCONFIG_MIN_PCS_URB_ENTRIES: case INTEL_HWCONFIG_MAX_PCS_URB_ENTRIES: break; /* ignore */ - case INTEL_HWCONFIG_MIN_HS_URB_ENTRIES: - DEVINFO_HWCONFIG(200, urb.min_entries[MESA_SHADER_TESS_CTRL], item); - break; case INTEL_HWCONFIG_MAX_HS_URB_ENTRIES: DEVINFO_HWCONFIG(200, urb.max_entries[MESA_SHADER_TESS_CTRL], item); break; - case INTEL_HWCONFIG_MIN_GS_URB_ENTRIES: - DEVINFO_HWCONFIG(200, urb.min_entries[MESA_SHADER_GEOMETRY], item); - break; case INTEL_HWCONFIG_MAX_GS_URB_ENTRIES: DEVINFO_HWCONFIG(200, urb.max_entries[MESA_SHADER_GEOMETRY], item); break; - case INTEL_HWCONFIG_MIN_DS_URB_ENTRIES: - DEVINFO_HWCONFIG(200, urb.min_entries[MESA_SHADER_TESS_EVAL], item); - break; case INTEL_HWCONFIG_MAX_DS_URB_ENTRIES: DEVINFO_HWCONFIG(200, urb.max_entries[MESA_SHADER_TESS_EVAL], item); break; + case INTEL_HWCONFIG_MIN_VS_URB_ENTRIES: + case INTEL_HWCONFIG_MIN_HS_URB_ENTRIES: + case INTEL_HWCONFIG_MIN_GS_URB_ENTRIES: + case INTEL_HWCONFIG_MIN_DS_URB_ENTRIES: case INTEL_HWCONFIG_PUSH_CONSTANT_URB_RESERVED_SIZE: case INTEL_HWCONFIG_POCS_PUSH_CONSTANT_URB_RESERVED_SIZE: case INTEL_HWCONFIG_URB_REGION_ALIGNMENT_SIZE_IN_BYTES: