build: avoid redefining unreachable() which is standard in C23

In the C23 standard unreachable() is now a predefined function-like
macro in <stddef.h>

See https://android.googlesource.com/platform/bionic/+/HEAD/docs/c23.md#is-now-a-predefined-function_like-macro-in

And this causes build errors when building for C23:

-----------------------------------------------------------------------
In file included from ../src/util/log.h:30,
                 from ../src/util/log.c:30:
../src/util/macros.h:123:9: warning: "unreachable" redefined
  123 | #define unreachable(str)    \
      |         ^~~~~~~~~~~
In file included from ../src/util/macros.h:31:
/usr/lib/gcc/x86_64-linux-gnu/14/include/stddef.h:456:9: note: this is the location of the previous definition
  456 | #define unreachable() (__builtin_unreachable ())
      |         ^~~~~~~~~~~
-----------------------------------------------------------------------

So don't redefine it with the same name, but use the name UNREACHABLE()
to also signify it's a macro.

Using a different name also makes sense because the behavior of the
macro was extending the one of __builtin_unreachable() anyway, and it
also had a different signature, accepting one argument, compared to the
standard unreachable() with no arguments.

This change improves the chances of building mesa with the C23 standard,
which for instance is the default in recent AOSP versions.

All the instances of the macro, including the definition, were updated
with the following command line:

  git grep -l '[^_]unreachable(' -- "src/**" | sort | uniq | \
  while read file; \
  do \
    sed -e 's/\([^_]\)unreachable(/\1UNREACHABLE(/g' -i "$file"; \
  done && \
  sed -e 's/#undef unreachable/#undef UNREACHABLE/g' -i src/intel/isl/isl_aux_info.c

Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36437>
This commit is contained in:
Antonio Ospite
2025-07-23 09:17:35 +02:00
committed by Marge Bot
parent b4c7d3a08e
commit ddf2aa3a4d
1079 changed files with 3741 additions and 3741 deletions
+3 -3
View File
@@ -2859,7 +2859,7 @@ TEST_P(validation_test, gfx11_no_byte_src_1_2)
brw_eu_inst_set_3src_a1_src1_hstride(&devinfo, last_inst, inst[i].srcs[0].hstride);
break;
default:
unreachable("invalid opcode");
UNREACHABLE("invalid opcode");
}
brw_eu_inst_set_dst_hstride(&devinfo, last_inst, BRW_HORIZONTAL_STRIDE_1);
@@ -3749,7 +3749,7 @@ TEST_P(validation_test, scalar_register_restrictions)
break;
}
default:
unreachable("unexpected opcode in tests");
UNREACHABLE("unexpected opcode in tests");
}
brw_eu_inst_set_exec_size(&devinfo, last_inst, cvt(t.exec_size) - 1);
@@ -3884,7 +3884,7 @@ TEST_P(validation_test, bfloat_restrictions)
brw_MAD(p, t.dst, t.src0, t.src1, t.src2);
break;
default:
unreachable("unexpected opcode in tests");
UNREACHABLE("unexpected opcode in tests");
}
if (tests[i].opcode == BRW_OPCODE_MAD) {