diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index f8380b0a542..ef5be716d93 100644 --- a/docs/submittingpatches.html +++ b/docs/submittingpatches.html @@ -259,15 +259,53 @@ Thus, drop the line only if you want to cancel the nomination.

Criteria for accepting patches to the stable branch

Mesa has a designated release manager for each stable branch, and the release -manager is the only developer that should be pushing changes to these -branches. Everyone else should simply nominate patches using the mechanism -described above. +manager is the only developer that should be pushing changes to these branches. +Everyone else should nominate patches using the mechanism described above. -The stable-release manager will work with the list of nominated patches, and -for each patch that meets the criteria below will cherry-pick the patch with: -git cherry-pick -x <commit>. The -x option is -important so that the picked patch references the commit ID of the original -patch. +The following rules define which patches are accepted and which are not. The +stable-release manager is also given broad discretion in rejecting patches +that have been nominated. + + + +If the patch complies with the rules it will be +cherry-picked. Alternatively the release +manager will reply to the patch in question stating why the patch has been +rejected or would request a backport. + +A summary of all the picked/rejected patches will be presented in the +pre-release announcement. The stable-release manager may at times need to force-push changes to the stable branches, for example, to drop a previously-picked patch that was later @@ -275,72 +313,6 @@ identified as causing a regression). These force-pushes may cause changes to be lost from the stable branch if developers push things directly. Consider yourself warned. -The stable-release manager is also given broad discretion in rejecting patches -that have been nominated for the stable branch. The most basic rule is that -the stable branch is for bug fixes only, (no new features, no -regressions). Here is a non-exhaustive list of some reasons that a patch may -be rejected: - - -

Git tips