From d482b6ca68666a4905a2561a92ddedd16972c157 Mon Sep 17 00:00:00 2001 From: "Eric R. Smith" Date: Fri, 29 Aug 2025 14:06:11 -0300 Subject: [PATCH] panfrost: fix typo in register allocation The intention of the code was to allow PHI values to be propagated if they were in registers (as opposed to in memory). As written though values were never propagated. I think this typo was due to some debug code that wasn't removed properly. Fixes: 6c64ad934f7 ("panfrost: spill registers in SSA form") Reviewed-by: Mary Guillemard Reviewed-by: Ashley Smith Part-of: --- src/panfrost/compiler/bi_ra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/panfrost/compiler/bi_ra.c b/src/panfrost/compiler/bi_ra.c index 0e879ec06cf..222600e2032 100644 --- a/src/panfrost/compiler/bi_ra.c +++ b/src/panfrost/compiler/bi_ra.c @@ -965,7 +965,7 @@ bi_out_of_ssa(bi_context *ctx) } /* Replace the phi with a move */ - allow_propagate = false; + allow_propagate = true; bi_builder b = bi_init_builder(ctx, bi_before_instr(I)); if (I->dest[0].memory) { /* dest was spilled to memory */