AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

intel/brw: Use the builder DO() function in all places

Browse Source 
Shorter and a preparation to add some functionality to DO().

Had to make it const since that's the convention for builder, so
just made all the sibling helpers const too.

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33536>
This commit is contained in:
Caio Oliveira
2025-02-13 19:20:38 -08:00
committed by Marge Bot
parent 5f8f3db475
commit d32a5ab0e4
3 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/intel/compiler/brw_builder.h
+6 -6
View File
@@ -846,12 +846,12 @@ public:
brw_shader *shader;
brw_inst *BREAK() { return emit(BRW_OPCODE_BREAK); }
brw_inst *DO() { return emit(BRW_OPCODE_DO); }
brw_inst *ENDIF() { return emit(BRW_OPCODE_ENDIF); }
brw_inst *NOP() { return emit(BRW_OPCODE_NOP); }
brw_inst *WHILE() { return emit(BRW_OPCODE_WHILE); }
brw_inst *CONTINUE() { return emit(BRW_OPCODE_CONTINUE); }
brw_inst *BREAK() const { return emit(BRW_OPCODE_BREAK); }
brw_inst *DO() const { return emit(BRW_OPCODE_DO); }
brw_inst *ENDIF() const { return emit(BRW_OPCODE_ENDIF); }
brw_inst *NOP() const { return emit(BRW_OPCODE_NOP); }
brw_inst *WHILE() const { return emit(BRW_OPCODE_WHILE); }
brw_inst *CONTINUE() const { return emit(BRW_OPCODE_CONTINUE); }
bool has_writemask_all() const {
return force_writemask_all;
src/intel/compiler/brw_from_nir.cpp
+2 -2
View File
@@ -469,7 +469,7 @@ brw_from_nir_emit_loop(nir_to_brw_state &ntb, nir_loop *loop)
const brw_builder &bld = ntb.bld;
assert(!nir_loop_has_continue_construct(loop));
bld.emit(BRW_OPCODE_DO);
bld.DO();
brw_from_nir_emit_cf_list(ntb, &loop->body);
@@ -7818,7 +7818,7 @@ brw_test_dispatch_packing(const brw_builder &bld)
/* This will loop forever if the dispatch mask doesn't have the expected
* form '2^n-1', in which case tmp will be non-zero.
*/
bld.emit(BRW_OPCODE_DO);
bld.DO();
bld.CMP(bld.null_reg_ud(), tmp, brw_imm_ud(0), BRW_CONDITIONAL_NZ);
set_predicate(BRW_PREDICATE_NORMAL, bld.emit(BRW_OPCODE_WHILE));
}
src/intel/compiler/test_lower_scoreboard.cpp
+3 -3
View File
@@ -505,7 +505,7 @@ TEST_F(scoreboard_test, loop1)
brw_reg x = bld.vgrf(BRW_TYPE_D);
bld.XOR( x, g[1], g[2]);
bld.emit(BRW_OPCODE_DO);
bld.DO();
bld.ADD( x, g[1], g[2]);
bld.emit(BRW_OPCODE_WHILE)->predicate = BRW_PREDICATE_NORMAL;
@@ -538,7 +538,7 @@ TEST_F(scoreboard_test, loop2)
bld.XOR(g[4], g[1], g[2]);
bld.XOR(g[5], g[1], g[2]);
bld.emit(BRW_OPCODE_DO);
bld.DO();
bld.ADD( x, g[1], g[2]);
bld.emit(BRW_OPCODE_WHILE)->predicate = BRW_PREDICATE_NORMAL;
@@ -570,7 +570,7 @@ TEST_F(scoreboard_test, loop3)
brw_reg x = bld.vgrf(BRW_TYPE_D);
bld.XOR( x, g[1], g[2]);
bld.emit(BRW_OPCODE_DO);
bld.DO();
/* For the ADD in the loop body this extra distance will always apply. */
bld.XOR(g[3], g[1], g[2]);