From d142c845d05732f7858839493e0dba6a1fa5d6c0 Mon Sep 17 00:00:00 2001 From: Matt Turner Date: Thu, 10 Aug 2023 14:12:24 -0400 Subject: [PATCH] Revert "intel/fs: only avoid SIMD32 if strictly inferior in throughput" This reverts commit 6b494745be0900a67004d6f3e4b730c3cd67da79. The logic is not entirely correct: the comparison is between two static-analysis estimates of a dynamic system with variables that aren't captured by the shader source, so using ">" will always have greater potential to cause regressions whenever the performance difference between the two builds is something not captured by the static model, no matter how much the model is improved. Reference: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9262 Part-of: --- src/intel/compiler/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp index 5e9f7983787..41ff3623ab2 100644 --- a/src/intel/compiler/brw_fs.cpp +++ b/src/intel/compiler/brw_fs.cpp @@ -7841,7 +7841,7 @@ brw_compile_fs(const struct brw_compiler *compiler, } else { const performance &perf = v32->performance_analysis.require(); - if (!INTEL_DEBUG(DEBUG_DO32) && throughput > perf.throughput) { + if (!INTEL_DEBUG(DEBUG_DO32) && throughput >= perf.throughput) { brw_shader_perf_log(compiler, params->base.log_data, "SIMD32 shader inefficient\n"); } else {