From cd1e7841487da739f926b699388fdf5b9967dba1 Mon Sep 17 00:00:00 2001 From: Connor Abbott Date: Fri, 5 Dec 2025 17:07:01 -0500 Subject: [PATCH] tu: Fix FragCoord offset when HW viewport offset is enabled FragCoord seems to have the offset applied to it, so we don't need to subtract it out. Fixes upcoming test dEQP-VK.renderpasses.dynamic_rendering.primary_cmd_buff.custom_resolve.monolithic.fdm_nonsubsampled_multiview_with_offset. Fixes: b34b089ca13 ("tu: Use GRAS bin offset registers") Part-of: --- src/freedreno/vulkan/tu_cmd_buffer.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/freedreno/vulkan/tu_cmd_buffer.cc b/src/freedreno/vulkan/tu_cmd_buffer.cc index c3c405b7ab1..e331c5966e2 100644 --- a/src/freedreno/vulkan/tu_cmd_buffer.cc +++ b/src/freedreno/vulkan/tu_cmd_buffer.cc @@ -7605,10 +7605,7 @@ fdm_apply_fs_params(struct tu_cmd_buffer *cmd, */ VkExtent2D area = frag_areas[MIN2(i, views - 1)]; VkRect2D bin = bins[MIN2(i, views - 1)]; - VkOffset2D hw_viewport_offset = hw_viewport_offsets[MIN2(i, views - 1)]; VkOffset2D offset = tu_fdm_per_bin_offset(area, bin, common_bin_offset); - offset.x -= hw_viewport_offset.x; - offset.y -= hw_viewport_offset.y; tu_cs_emit(cs, area.width); tu_cs_emit(cs, area.height);