From cc1c663152095b355d96ea2b61f2e34987f44fa0 Mon Sep 17 00:00:00 2001 From: Chia-I Wu Date: Mon, 28 Oct 2024 11:34:03 -0700 Subject: [PATCH] panvk: disable depth write when depth test is disabled The spec says depthWriteEnable controls whether depth writes are enabled when depthTestEnable is VK_TRUE. Depth writes are always disabled when depthTestEnable is VK_FALSE. Signed-off-by: Chia-I Wu Reviewed-By: Benjamin Lee Reviewed-by: Boris Brezillon Part-of: --- src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c b/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c index 7c3d8c3e810..dee17c4a644 100644 --- a/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c +++ b/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c @@ -1116,7 +1116,7 @@ prepare_ds(struct panvk_cmd_buffer *cmdbuf) if (fs) cfg.depth_source = pan_depth_source(&fs->info); - cfg.depth_write_enable = ds->depth.write_enable; + cfg.depth_write_enable = test_z && ds->depth.write_enable; cfg.depth_bias_enable = rs->depth_bias.enable; cfg.depth_function = test_z ? translate_compare_func(ds->depth.compare_op) : MALI_FUNC_ALWAYS;