From c881e718d4424891a5d067de81bcd6e14a08e6cc Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Mon, 9 May 2022 12:57:13 +0200 Subject: [PATCH] v3dv: expose separateDepthStencilLayouts MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is actually required by Vulkan 1.2 and to expose the extension, so let's conform to this requirement, we don't really care since image layouts are not relevant to our current implementation. Fixes: 1442d77bc5 ('v3dv: trivially implement VK_KHR_separate_depth_stencil_layouts') Fixes: dEQP-VK.info.device_mandatory_features Reviewed-by: Alejandro Piñeiro Part-of: --- src/broadcom/vulkan/v3dv_device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/broadcom/vulkan/v3dv_device.c b/src/broadcom/vulkan/v3dv_device.c index 70e5958222b..4e4a56cd270 100644 --- a/src/broadcom/vulkan/v3dv_device.c +++ b/src/broadcom/vulkan/v3dv_device.c @@ -1181,10 +1181,10 @@ v3dv_GetPhysicalDeviceFeatures2(VkPhysicalDevice physicalDevice, * generally don't care about layouts, so again, we don't get any * benefits from this to limit the scope of image layout transitions. * - * Since we cannot offer any advantages to applications that use separate - * layouts for D/S, don't expose the feature. + * Still, Vulkan 1.2 requires this feature to be supported so we + * advertise it even though we don't really take advantage of it. */ - .separateDepthStencilLayouts = false, + .separateDepthStencilLayouts = true, .storageBuffer8BitAccess = true, .storagePushConstant8 = true, .imagelessFramebuffer = true,