From c6ebd2de71dc2819400b404be0e3d50924302410 Mon Sep 17 00:00:00 2001 From: Tatsuyuki Ishi Date: Tue, 7 Feb 2023 23:57:57 +0900 Subject: [PATCH] radv: Fix noop FS not getting constructed for GPL pipelines. The condition was inverted, causing compilation to be actually skipped when a noop FS is used and straight emitting the pipeline from the default initialized struct. Fixes: 3eb97b9d334 ("radv: skip compilation when possible with GPL fast-linking") Part-of: --- src/amd/vulkan/radv_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 903bedbab2e..6d46783f1e5 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_pipeline.c @@ -3473,7 +3473,7 @@ radv_skip_graphics_pipeline_compile(const struct radv_graphics_pipeline *pipelin /* Do not skip when the linked pipeline needs a noop FS. */ if ((lib_flags & VK_GRAPHICS_PIPELINE_LIBRARY_FRAGMENT_SHADER_BIT_EXT) && - pipeline->active_stages & VK_SHADER_STAGE_FRAGMENT_BIT) + !(pipeline->active_stages & VK_SHADER_STAGE_FRAGMENT_BIT)) return false; /* Do not skip when the PS epilog needs to be compiled. */