From c157e8991e10958e7e23f72207a9f54bac8160ca Mon Sep 17 00:00:00 2001 From: "Juan A. Suarez Romero" Date: Mon, 1 Jul 2024 12:38:54 +0200 Subject: [PATCH] v3d: use original enabled_mask on setting vertex buffers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Current code uses a non-initialized enabled_mask to set the vertex buffers mask, instead of using the original value from `so->enabled_mask` Let's use the original field instead of using an intermediate variable. Fixes: cbcfb34cf78 ("v3d: use BITSET for the masks") Reviewed-by: Alejandro PiƱeiro Reviewed-by: Iago Toral Quiroga Signed-off-by: Juan A. Suarez Romero Part-of: --- src/gallium/drivers/v3d/v3dx_state.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gallium/drivers/v3d/v3dx_state.c b/src/gallium/drivers/v3d/v3dx_state.c index 4bdb46d811a..1f1ae2420cc 100644 --- a/src/gallium/drivers/v3d/v3dx_state.c +++ b/src/gallium/drivers/v3d/v3dx_state.c @@ -298,10 +298,8 @@ v3d_set_vertex_buffers(struct pipe_context *pctx, struct v3d_vertexbuf_stateobj *so = &v3d->vertexbuf; assert(BITSET_SIZE(so->enabled_mask) <= 32); - uint32_t enabled_mask; - util_set_vertex_buffers_mask(so->vb, &enabled_mask, vb, + util_set_vertex_buffers_mask(so->vb, &so->enabled_mask[0], vb, count, true); - memcpy(&so->enabled_mask, &enabled_mask, sizeof(enabled_mask)); so->count = BITSET_LAST_BIT(so->enabled_mask);