AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

glapi: fixup EXT_multisampled_render_to_texture dispatch

Browse Source 
There's a few missing and convoluted bits:

 - FramebufferTexture2DMultisampleEXT
Missing sanity check, should be desktop="false"

 - RenderbufferStorageMultisampleEXT
Missing sanity check, is aliased to RenderbufferStorageMultisample.
Thus it's set only when desktop GL or GLES2 v3.0+, while the extension
is GLES2 2.0+.

If we flip the aliasing we'll break indirect GLX, so loosen the version
to 2.0. Not perfect, yet this is the most sane thing I could think of.

v2: [Emil] Fixup RenderbufferStorageMultisampleEXT, commmit message

Cc: Kristian H. Kristensen <hoegsberg@gmail.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108974
Fixes: 1b331ae505 ("mesa: Add core support for EXT_multisampled_render_to_texture{,2}")
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
This commit is contained in:
Kristian H. Kristensen
2018-12-10 18:14:34 +00:00
committed by Kristian H. Kristensen
parent 9578dde1c8
commit c0de7c21a3
5 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/mapi/glapi/gen/ARB_framebuffer_object.xml
+9 -1
View File
@@ -172,7 +172,15 @@
<glx rop="4318"/>
</function>
<function name="RenderbufferStorageMultisample" es2="3.0">
<!--
The EXT aliasee, as part of EXT_multisampled_render_to_texture can
work on GLES 2.0. While the entry point below is only set when
gl || (gles && version > 3.0)
As such, the entrypoint will be noop, and calling it will do nothing.
Workaround that by loosening the version to 2.0.
-->
<function name="RenderbufferStorageMultisample" es2="2.0">
<param name="target" type="GLenum"/>
<param name="samples" type="GLsizei"/>
<param name="internalformat" type="GLenum"/>