From c0d1b199ae99d5b9573d4d09cf8be44003e806fe Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Corentin=20No=C3=ABl?= <corentin.noel@collabora.com>
Date: Thu, 12 Jun 2025 14:37:17 +0200
Subject: [PATCH] venus: Fix leak in syncobj creation failure path
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

CID: 1475984 Resource leak
Signed-off-by: Corentin Noël <corentin.noel@collabora.com>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35474>
---
 src/virtio/vulkan/vn_renderer_virtgpu.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/virtio/vulkan/vn_renderer_virtgpu.c b/src/virtio/vulkan/vn_renderer_virtgpu.c
index e9316fbe6ef..5b199aaadb2 100644
--- a/src/virtio/vulkan/vn_renderer_virtgpu.c
+++ b/src/virtio/vulkan/vn_renderer_virtgpu.c
@@ -158,6 +158,8 @@ sim_syncobj_create(struct virtgpu *gpu, bool signaled)
       sim.syncobjs = _mesa_pointer_hash_table_create(NULL);
       if (!sim.syncobjs) {
          mtx_unlock(&sim.mutex);
+         mtx_destroy(&syncobj->mutex);
+         free(syncobj);
          return 0;
       }
 
@@ -172,6 +174,8 @@ sim_syncobj_create(struct virtgpu *gpu, bool signaled)
          _mesa_hash_table_destroy(sim.syncobjs, NULL);
          sim.syncobjs = NULL;
          mtx_unlock(&sim.mutex);
+         mtx_destroy(&syncobj->mutex);
+         free(syncobj);
          return 0;
       }