From c0191b20de5f41c0c66ac534d6b735275c4916bb Mon Sep 17 00:00:00 2001 From: Faith Ekstrand Date: Mon, 26 Aug 2024 17:28:44 -0500 Subject: [PATCH] vulkan/pipeline: Handle VIEW_INDEX_FROM_DEVICE_INDEX_BIT The rehash we're doing here is a bit of a hack but it's a back-portable hack. We'll fix it properly in following commits. Fixes: 9308e8d90d26 ("vulkan: Add generic graphics and compute VkPipeline implementations") Reviewed-by: Ivan Briano Reviewed-by: Samuel Pitoiset Part-of: --- src/vulkan/runtime/vk_pipeline.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/vulkan/runtime/vk_pipeline.c b/src/vulkan/runtime/vk_pipeline.c index 6c68b23d6ca..990ec1b3d97 100644 --- a/src/vulkan/runtime/vk_pipeline.c +++ b/src/vulkan/runtime/vk_pipeline.c @@ -820,6 +820,16 @@ vk_pipeline_precompile_shader(struct vk_device *device, uint8_t stage_sha1[SHA1_DIGEST_LENGTH]; vk_pipeline_hash_shader_stage(info, &rs, stage_sha1); + /* This bit affects shader compilation but isn't taken into account in + * vk_pipeline_hash_shader_stage(). Re-hash the SHA1 if it's set. + */ + if (pipeline_flags & VK_PIPELINE_CREATE_2_VIEW_INDEX_FROM_DEVICE_INDEX_BIT_KHR) { + struct mesa_sha1 ctx; + _mesa_sha1_init(&ctx); + _mesa_sha1_update(&ctx, stage_sha1, sizeof(stage_sha1)); + _mesa_sha1_final(&ctx, stage_sha1); + } + if (cache != NULL) { struct vk_pipeline_cache_object *cache_obj = vk_pipeline_cache_lookup_object(cache, stage_sha1, sizeof(stage_sha1), @@ -847,6 +857,9 @@ vk_pipeline_precompile_shader(struct vk_device *device, if (result != VK_SUCCESS) return result; + if (pipeline_flags & VK_PIPELINE_CREATE_2_VIEW_INDEX_FROM_DEVICE_INDEX_BIT_KHR) + NIR_PASS(_, nir, nir_lower_view_index_to_device_index); + if (ops->preprocess_nir != NULL) ops->preprocess_nir(device->physical, nir);