From bf3cd28319cbf06b6bc97064dfb0cd054700c274 Mon Sep 17 00:00:00 2001 From: Boris Brezillon Date: Sun, 18 Oct 2020 09:47:45 +0200 Subject: [PATCH] panfrost: Use real name for attribute's unknown field Signed-off-by: Boris Brezillon Reviewed-by: Alyssa Rosenzweig Part-of: --- src/gallium/drivers/panfrost/pan_cmdstream.c | 4 ++-- src/panfrost/bifrost/test/bi_submit.c | 4 ++-- src/panfrost/lib/midgard.xml | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_cmdstream.c b/src/gallium/drivers/panfrost/pan_cmdstream.c index e4cb4424d0f..49f1c2ce057 100644 --- a/src/gallium/drivers/panfrost/pan_cmdstream.c +++ b/src/gallium/drivers/panfrost/pan_cmdstream.c @@ -1490,7 +1490,7 @@ pan_emit_vary(struct mali_attribute_packed *out, pan_pack(out, ATTRIBUTE, cfg) { cfg.buffer_index = pan_varying_index(present, buf); - cfg.unknown = quirks & IS_BIFROST ? 0x0 : 0x1; + cfg.offset_enable = quirks & IS_BIFROST ? false : true; cfg.format = (format << 12) | swizzle; cfg.offset = offset; } @@ -1553,7 +1553,7 @@ pan_emit_vary_xfb(struct mali_attribute_packed *out, pan_pack(out, ATTRIBUTE, cfg) { /* XFB buffers come after everything else */ cfg.buffer_index = pan_xfb_base(present) + o.output_buffer; - cfg.unknown = quirks & IS_BIFROST ? 0x0 : 0x1; + cfg.offset_enable = quirks & IS_BIFROST ? false : true; /* Override number of channels and precision to highp */ cfg.format = (pan_xfb_format(format, o.num_components) << 12) | swizzle; diff --git a/src/panfrost/bifrost/test/bi_submit.c b/src/panfrost/bifrost/test/bi_submit.c index fd015995cd8..0c2ee93776a 100644 --- a/src/panfrost/bifrost/test/bi_submit.c +++ b/src/panfrost/bifrost/test/bi_submit.c @@ -138,12 +138,12 @@ bit_vertex(struct panfrost_device *dev, panfrost_program *prog, pan_pack(attr->cpu, ATTRIBUTE, cfg) { cfg.format = (MALI_RGBA32UI << 12); - cfg.unknown = true; + cfg.offset_enable = true; } pan_pack(var->cpu, ATTRIBUTE, cfg) { cfg.format = (MALI_RGBA32UI << 12); - cfg.unknown = false; + cfg.offset_enable = false; } pan_pack(var->cpu + 256, ATTRIBUTE_BUFFER, cfg) { diff --git a/src/panfrost/lib/midgard.xml b/src/panfrost/lib/midgard.xml index 6d35e34a874..98aff43a741 100644 --- a/src/panfrost/lib/midgard.xml +++ b/src/panfrost/lib/midgard.xml @@ -345,7 +345,7 @@ - +