From be9621363428aaf92620c3c0e4692a560409a4e0 Mon Sep 17 00:00:00 2001 From: Boris Brezillon Date: Fri, 2 Aug 2024 16:10:14 +0200 Subject: [PATCH] panvk: Make sure push sets are reset when picked from the CommandPool If we don't do that, we might end up with data from the previous user of this set. Fixes: 598a8d9d11f5 ("panvk: Collect allocated push sets at the command level") Signed-off-by: Boris Brezillon Reviewed-by: Rebecca Mckeever Reviewed-by: Mary Guillemard Reviewed-by: Lars-Ivar Hesselberg Simonsen Reviewed-by: John Anthony Acked-by: Erik Faye-Lund Part-of: --- src/panfrost/vulkan/panvk_vX_cmd_desc_state.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/panfrost/vulkan/panvk_vX_cmd_desc_state.c b/src/panfrost/vulkan/panvk_vX_cmd_desc_state.c index 1df72a97649..00d2ada742a 100644 --- a/src/panfrost/vulkan/panvk_vX_cmd_desc_state.c +++ b/src/panfrost/vulkan/panvk_vX_cmd_desc_state.c @@ -83,6 +83,7 @@ panvk_per_arch(cmd_push_descriptors)(struct vk_command_buffer *vk_cmdbuf, list_first_entry(&pool->push_sets, struct panvk_push_set, base.node); list_del(&push_set->base.node); list_addtail(&push_set->base.node, &cmdbuf->push_sets); + memset(push_set->descs, 0, sizeof(push_set->descs)); } else { push_set = vk_zalloc(&pool->vk.alloc, sizeof(*push_set), 8, VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);