From bb35195b73824d2aa4ac89aa80ff84f54bc9b108 Mon Sep 17 00:00:00 2001 From: Emma Anholt Date: Tue, 13 Jul 2021 16:31:52 -0700 Subject: [PATCH] nir: Validate after deserialization. It's a particularly relevant place for NIR bugs to occur, and if you make a mistake in this code it gets caught in your debug build in something like mesa/st's call to nir_split_var_copies() during finalization, which is rather misleading. Reviewed-by: Jason Ekstrand Reviewed-by: Rob Clark Part-of: --- src/compiler/nir/nir_serialize.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/nir/nir_serialize.c b/src/compiler/nir/nir_serialize.c index cc376cbcb6b..f9fc3193c6e 100644 --- a/src/compiler/nir/nir_serialize.c +++ b/src/compiler/nir/nir_serialize.c @@ -2102,6 +2102,8 @@ nir_deserialize(void *mem_ctx, free(ctx.idx_table); + nir_validate_shader(ctx.nir, "after deserialize"); + return ctx.nir; }