From b874a2ed61b056fd69fc2aa4cbf2291d95177b23 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timur=20Krist=C3=B3f?= Date: Wed, 13 Apr 2022 14:11:18 +0200 Subject: [PATCH] aco: Fix VOP2 instruction format in visit_tex. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There was a v_or_b32 that accidentally used SOP2. It should use VOP2. Issue found by looking at a gfxreconstruct trace posted by a user in this bug: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5838 Cc: mesa-stable Fixes: 93c8ebfa780ebd1495095e794731881aef29e7d3 "aco: Initial commit of independent AMD compiler" Signed-off-by: Timur Kristóf Reviewed-by: Daniel Schürmann Part-of: --- src/amd/compiler/aco_instruction_selection.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/compiler/aco_instruction_selection.cpp b/src/amd/compiler/aco_instruction_selection.cpp index 7caba87e134..887591c321c 100644 --- a/src/amd/compiler/aco_instruction_selection.cpp +++ b/src/amd/compiler/aco_instruction_selection.cpp @@ -9083,7 +9083,7 @@ visit_tex(isel_context* ctx, nir_tex_instr* instr) } if (pack_const && pack != Temp()) - pack = bld.sop2(aco_opcode::v_or_b32, bld.def(v1), Operand::c32(pack_const), pack); + pack = bld.vop2(aco_opcode::v_or_b32, bld.def(v1), Operand::c32(pack_const), pack); } if (pack_const && pack == Temp()) offset = bld.copy(bld.def(v1), Operand::c32(pack_const));