From b589285468c5b5045c5a9554f0601ff00d4a3194 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Mon, 3 Feb 2025 17:05:48 -0500 Subject: [PATCH] agx: assert shift bounds would've saved me a lot of dbg trouble.. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/asahi/compiler/agx_compile.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/asahi/compiler/agx_compile.c b/src/asahi/compiler/agx_compile.c index 69f3d01901c..251cf0cd675 100644 --- a/src/asahi/compiler/agx_compile.c +++ b/src/asahi/compiler/agx_compile.c @@ -740,6 +740,8 @@ agx_emit_load(agx_builder *b, agx_index dest, nir_intrinsic_instr *instr) enum agx_format fmt = agx_format_for_pipe(nir_intrinsic_format(instr)); unsigned shift = nir_intrinsic_base(instr); + assert(shift <= 3); + /* Zero-extend offset if we're not sign-extending */ if (!nir_intrinsic_sign_extend(instr)) offset = agx_abs(offset); @@ -758,6 +760,8 @@ agx_emit_store(agx_builder *b, nir_intrinsic_instr *instr) enum agx_format fmt = agx_format_for_pipe(nir_intrinsic_format(instr)); unsigned shift = nir_intrinsic_base(instr); + assert(shift <= 3); + /* Zero-extend offset if we're not sign-extending */ if (!nir_intrinsic_sign_extend(instr)) offset = agx_abs(offset);