From b4ebffa1aa2bd68a468e040fd0ca1f319b8c4c4a Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Mon, 10 Mar 2025 16:33:17 +0100 Subject: [PATCH] panfrost: fixup typo in 16x sample-pattern This is an n-queen pattern, where no two values should be on the same row or column. But this and the second to last element has the same y component, and neither has the negative one. Let's fix this up by setting the first value to the negative value. This matches the D3D 16x sample pattern. Fixes: a61fb629665 ("panfrost: Upload sample positions on device init") Reviewed-by: Lars-Ivar Hesselberg Simonsen Part-of: --- src/panfrost/lib/pan_samples.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/panfrost/lib/pan_samples.c b/src/panfrost/lib/pan_samples.c index 02b60caa804..a03647c215c 100644 --- a/src/panfrost/lib/pan_samples.c +++ b/src/panfrost/lib/pan_samples.c @@ -115,7 +115,7 @@ const struct mali_sample_positions sample_position_lut[] = { SAMPLE16( 5, 3), SAMPLE16( 3, -5), SAMPLE16(-2, 6), - SAMPLE16( 0, 7), + SAMPLE16( 0, -7), SAMPLE16(-4, -6), SAMPLE16(-6, 4), SAMPLE16(-8, 0),