From b1b125dbe6cc1e797c6724ad9ffcb15fd08cba84 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Wed, 16 Oct 2024 09:54:38 -0400 Subject: [PATCH] hk: drop store_op_dontcare w/a updated CTS fixes this. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/asahi/vulkan/hk_cmd_draw.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/asahi/vulkan/hk_cmd_draw.c b/src/asahi/vulkan/hk_cmd_draw.c index 2622346d229..7412e7cb96e 100644 --- a/src/asahi/vulkan/hk_cmd_draw.c +++ b/src/asahi/vulkan/hk_cmd_draw.c @@ -388,15 +388,8 @@ hk_build_bg_eot(struct hk_cmd_buffer *cmd, const VkRenderingInfo *info, * Optimizing this would require nontrivial tracking. Fortunately, * this is all Android gunk and we don't have to care too much for * dekstop games. So do the simple thing. - * - * VK_ATTACHMENT_STORE_OP_DONT_CARE does not need this workaround, - * fortunately. It's just here as a temporary stopgap to workaround CTS - * issue #5369. */ - bool no_store = - (att_info->storeOp == VK_ATTACHMENT_STORE_OP_NONE) || - (att_info->storeOp == VK_ATTACHMENT_STORE_OP_DONT_CARE); - + bool no_store = (att_info->storeOp == VK_ATTACHMENT_STORE_OP_NONE); bool no_store_wa = no_store && !load && !clear; if (no_store_wa) { perf_debug(dev, "STORE_OP_NONE workaround");