From ac051c556d0035c98ad07f44aa89f7438f9e414d Mon Sep 17 00:00:00 2001 From: Connor Abbott Date: Thu, 29 Sep 2022 17:58:59 +0200 Subject: [PATCH] tu: Don't use rasterizationSamples when enabling sample shading From the spec language, it seems like this change wasn't strictly required and is just an optimization for when minSampleShading would be small enough to allow one sample per pixel. However rasterizationSamples will soon possibly be dynamic, and I don't think we should keep this around. Part-of: --- src/freedreno/vulkan/tu_pipeline.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/freedreno/vulkan/tu_pipeline.c b/src/freedreno/vulkan/tu_pipeline.c index e041e6c64b7..93ebbf046be 100644 --- a/src/freedreno/vulkan/tu_pipeline.c +++ b/src/freedreno/vulkan/tu_pipeline.c @@ -2629,8 +2629,7 @@ tu_pipeline_shader_key_init(struct ir3_shader_key *key, * just checked in tu6_emit_fs_inputs. We will also copy the value to * tu_shader_key::force_sample_interp in a bit. */ - if (msaa_info && msaa_info->sampleShadingEnable && - (msaa_info->minSampleShading * msaa_info->rasterizationSamples) > 1.0f) + if (msaa_info && msaa_info->sampleShadingEnable) key->sample_shading = true; }