From abca6c97a0d173ddf3b65e1cf5fdf51c2bff8b77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Pi=C3=B1eiro?= Date: Tue, 8 Sep 2020 00:57:31 +0200 Subject: [PATCH] v3dv/formats: properly return unsupported for 1D compressed textures Gets tests like the following one properly skipped: dEQP-VK.api.copy_and_blit.core.image_to_image.all_formats.color.1d.etc2_r8g8b8a8_unorm_block.etc2_r8g8b8a8_unorm_block.optimal_general Part-of: --- src/broadcom/vulkan/v3dv_formats.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/broadcom/vulkan/v3dv_formats.c b/src/broadcom/vulkan/v3dv_formats.c index 3e898d66c00..e2d96223269 100644 --- a/src/broadcom/vulkan/v3dv_formats.c +++ b/src/broadcom/vulkan/v3dv_formats.c @@ -650,6 +650,12 @@ get_image_format_properties( unreachable("bad VkImageType"); } + /* Our hw doesn't support 1D compressed textures. */ + if (info->type == VK_IMAGE_TYPE_1D && + vk_format_is_compressed(info->format)) { + goto unsupported; + } + /* From the Vulkan 1.0 spec, section 34.1.1. Supported Sample Counts: * * sampleCounts will be set to VK_SAMPLE_COUNT_1_BIT if at least one of the