From a9095f0dbf6deae508b43eeb993d2a4427d66ccd Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Tue, 24 Sep 2024 16:21:40 +0200 Subject: [PATCH] radv: do not keep executable info when compiling shaders for ESO This is completely useless and it's wasting memory. Cc: mesa-stable Signed-off-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_shader_object.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_shader_object.c b/src/amd/vulkan/radv_shader_object.c index 78bb1c178a1..36f55a4af4d 100644 --- a/src/amd/vulkan/radv_shader_object.c +++ b/src/amd/vulkan/radv_shader_object.c @@ -183,7 +183,7 @@ radv_shader_object_init_graphics(struct radv_shader_object *shader_obj, struct r struct radv_shader *shaders[MESA_VULKAN_SHADER_STAGES] = {NULL}; struct radv_shader_binary *binaries[MESA_VULKAN_SHADER_STAGES] = {NULL}; - radv_graphics_shaders_compile(device, NULL, stages, &gfx_state, true, false, false, NULL, false, shaders, + radv_graphics_shaders_compile(device, NULL, stages, &gfx_state, false, false, false, NULL, false, shaders, binaries, &shader_obj->gs.copy_shader, &shader_obj->gs.copy_binary); shader = shaders[stage]; @@ -202,7 +202,7 @@ radv_shader_object_init_graphics(struct radv_shader_object *shader_obj, struct r radv_shader_stage_init(pCreateInfo, &stages[stage]); stages[stage].next_stage = next_stage; - radv_graphics_shaders_compile(device, NULL, stages, &gfx_state, true, false, false, NULL, false, shaders, + radv_graphics_shaders_compile(device, NULL, stages, &gfx_state, false, false, false, NULL, false, shaders, binaries, &shader_obj->gs.copy_shader, &shader_obj->gs.copy_binary); shader = shaders[stage]; @@ -248,7 +248,7 @@ radv_shader_object_init_compute(struct radv_shader_object *shader_obj, struct ra radv_shader_stage_init(pCreateInfo, &stage); - struct radv_shader *cs_shader = radv_compile_cs(device, NULL, &stage, true, false, false, &cs_binary); + struct radv_shader *cs_shader = radv_compile_cs(device, NULL, &stage, false, false, false, &cs_binary); ralloc_free(stage.nir); @@ -509,7 +509,7 @@ radv_shader_object_create_linked(VkDevice _device, uint32_t createInfoCount, con struct radv_shader *gs_copy_shader = NULL; struct radv_shader_binary *gs_copy_binary = NULL; - radv_graphics_shaders_compile(device, NULL, stages, &gfx_state, true, false, false, NULL, false, shaders, binaries, + radv_graphics_shaders_compile(device, NULL, stages, &gfx_state, false, false, false, NULL, false, shaders, binaries, &gs_copy_shader, &gs_copy_binary); for (unsigned i = 0; i < createInfoCount; i++) {