AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

glsl: In ir_validate, check that ir_loop::counter always refers to a new var.

Browse Source 
The compiler back-ends (i965's fs_visitor and brw_visitor,
ir_to_mesa_visitor, and glsl_to_tgsi_visitor) have been assuming this
for some time.  Thanks to the preceding patch, the compiler front-end
no longer breaks this assumption.

This patch adds code to validate the assumption so that if we have
future bugs, we'll be able to catch them earlier.

Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
This commit is contained in:
Paul Berry
2013-11-27 10:12:53 -08:00
parent d6eb4321d0
commit a810db7b84
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/glsl/ir_validate.cpp
+13
View File
@@ -63,6 +63,7 @@ public:
virtual ir_visitor_status visit_enter(ir_if *ir);
virtual ir_visitor_status visit_enter(ir_loop *ir);
virtual ir_visitor_status visit_leave(ir_loop *ir);
virtual ir_visitor_status visit_enter(ir_function *ir);
virtual ir_visitor_status visit_leave(ir_function *ir);
@@ -148,6 +149,18 @@ ir_validate::visit_enter(ir_if *ir)
}
ir_visitor_status
ir_validate::visit_enter(ir_loop *ir)
{
if (ir->counter != NULL && hash_table_find(ht, ir->counter) != NULL) {
printf("ir_loop @ %p specifies already-declared variable `%s' @ %p\n",
(void *) ir, ir->counter->name, (void *) ir->counter);
abort();
}
return visit_continue;
}
ir_visitor_status
ir_validate::visit_leave(ir_loop *ir)
{