From a12b844d40187c582c47dddfeecf91d4dd1643df Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Tue, 20 Apr 2021 13:09:09 +0200 Subject: [PATCH] radv: fix emitting default depth bounds state on GFX6 GFX6 has no CLEAR_STATE. One step towards Vulkan conformance on these old chips. Cc: 21.1 mesa-stable Signed-off-by: Samuel Pitoiset Reviewed-by: Bas Nieuwenhuizen Part-of: --- src/amd/ci/deqp-radv-oland-aco-fails.txt | 2 -- src/amd/ci/deqp-radv-pitcairn-aco-fails.txt | 2 -- src/amd/vulkan/radv_cmd_buffer.c | 3 ++- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/amd/ci/deqp-radv-oland-aco-fails.txt b/src/amd/ci/deqp-radv-oland-aco-fails.txt index f205e2408f0..322f0e907af 100644 --- a/src/amd/ci/deqp-radv-oland-aco-fails.txt +++ b/src/amd/ci/deqp-radv-oland-aco-fails.txt @@ -1,5 +1,3 @@ -dEQP-VK.pipeline.depth.format.d16_unorm.compare_ops.never_zerodepthbounds_depthdisabled_stencilenabled,Fail -dEQP-VK.pipeline.depth.format.d32_sfloat.compare_ops.never_zerodepthbounds_depthdisabled_stencilenabled,Fail dEQP-VK.robustness.robustness2.bind.notemplate.r32f.dontunroll.volatile.storage_buffer.no_fmt_qual.len_12.samples_1.1d.comp,Fail dEQP-VK.robustness.robustness2.bind.notemplate.r32f.dontunroll.volatile.storage_buffer.no_fmt_qual.len_12.samples_1.1d.frag,Fail dEQP-VK.robustness.robustness2.bind.notemplate.r32f.dontunroll.volatile.storage_buffer.no_fmt_qual.len_12.samples_1.1d.vert,Fail diff --git a/src/amd/ci/deqp-radv-pitcairn-aco-fails.txt b/src/amd/ci/deqp-radv-pitcairn-aco-fails.txt index 8a40ac3ed3b..3cbc83d8cdc 100644 --- a/src/amd/ci/deqp-radv-pitcairn-aco-fails.txt +++ b/src/amd/ci/deqp-radv-pitcairn-aco-fails.txt @@ -1,5 +1,3 @@ -dEQP-VK.pipeline.depth.format.d16_unorm.compare_ops.never_zerodepthbounds_depthdisabled_stencilenabled,Fail -dEQP-VK.pipeline.depth.format.d32_sfloat.compare_ops.never_zerodepthbounds_depthdisabled_stencilenabled,Fail dEQP-VK.robustness.robustness2.bind.notemplate.r32f.dontunroll.volatile.storage_buffer.no_fmt_qual.len_12.samples_1.1d.comp,Fail dEQP-VK.robustness.robustness2.bind.notemplate.r32f.dontunroll.volatile.storage_buffer.no_fmt_qual.len_12.samples_1.1d.frag,Fail dEQP-VK.robustness.robustness2.bind.notemplate.r32f.dontunroll.volatile.storage_buffer.no_fmt_qual.len_12.samples_1.1d.vert,Fail diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index d005da75db8..1d9646b461f 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -1263,7 +1263,8 @@ radv_emit_graphics_pipeline(struct radv_cmd_buffer *cmd_buffer) if (!cmd_buffer->state.emitted_pipeline) cmd_buffer->state.dirty |= RADV_CMD_DIRTY_DYNAMIC_PRIMITIVE_TOPOLOGY | - RADV_CMD_DIRTY_DYNAMIC_DEPTH_BIAS; + RADV_CMD_DIRTY_DYNAMIC_DEPTH_BIAS | + RADV_CMD_DIRTY_DYNAMIC_DEPTH_BOUNDS; if (!cmd_buffer->state.emitted_pipeline || cmd_buffer->state.emitted_pipeline->graphics.db_depth_control !=