From a09b6551ffb47ee3e78a82101945eac28369c387 Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Wed, 3 Sep 2025 14:00:21 +0200 Subject: [PATCH] pvr: remove stale comment about pvr_pds_upload The pvr_pds_upload struct has been moved to pvr_common.h, which doesn't have the same circular dependency issue here. But this change is out of scope for this MR, so let's just update the comment here instead. Reviewed-by: Simon Perretta Part-of: --- src/imagination/vulkan/pvr_spm.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/imagination/vulkan/pvr_spm.h b/src/imagination/vulkan/pvr_spm.h index e50c093edbd..67cd9335a31 100644 --- a/src/imagination/vulkan/pvr_spm.h +++ b/src/imagination/vulkan/pvr_spm.h @@ -64,9 +64,7 @@ struct pvr_spm_eot_state { struct pvr_suballoc_bo *usc_eot_program; - /* TODO: Make this struct pvr_pds_upload? It would pull in pvr_private.h - * though which causes a cycle since that includes pvr_spm.h . - */ + /* TODO: Make this struct pvr_pds_upload? */ /* This is only the data section upload. The code was uploaded at device * creation. */ @@ -77,9 +75,7 @@ struct pvr_spm_eot_state { struct pvr_spm_bgobj_state { struct pvr_bo *consts_buffer; - /* TODO: Make this struct pvr_pds_upload? It would pull in pvr_private.h - * though which causes a cycle since that includes pvr_spm.h . - */ + /* TODO: Make this struct pvr_pds_upload? */ struct pvr_suballoc_bo *pds_texture_data_upload; uint64_t pds_reg_values[ROGUE_NUM_CR_PDS_BGRND_WORDS];