From a04e172042895d9958537f8229b81a3ab858fea6 Mon Sep 17 00:00:00 2001 From: Job Noorman Date: Thu, 31 Jul 2025 08:52:45 +0200 Subject: [PATCH] tu: disable VK_EXT_post_depth_coverage The HW returns the wrong result for gl_SampleMaskIn when post_depth_coverage is enabled together with FSR. This is especially problematic since we use gl_SampleMaskIn to lower gl_HelperInvocation. Disable the extension as a workaround. We are currently unaware of any apps that use VK_EXT_post_depth_coverage so disabling it should not be a problem. Signed-off-by: Job Noorman Part-of: --- src/freedreno/vulkan/tu_device.cc | 1 - src/freedreno/vulkan/tu_shader.cc | 1 - 2 files changed, 2 deletions(-) diff --git a/src/freedreno/vulkan/tu_device.cc b/src/freedreno/vulkan/tu_device.cc index 55659a56257..a2d68c157c8 100644 --- a/src/freedreno/vulkan/tu_device.cc +++ b/src/freedreno/vulkan/tu_device.cc @@ -316,7 +316,6 @@ get_device_extensions(const struct tu_physical_device *device, .EXT_physical_device_drm = !is_kgsl(device->instance), .EXT_pipeline_creation_cache_control = true, .EXT_pipeline_creation_feedback = true, - .EXT_post_depth_coverage = true, .EXT_primitive_topology_list_restart = true, .EXT_primitives_generated_query = true, .EXT_private_data = true, diff --git a/src/freedreno/vulkan/tu_shader.cc b/src/freedreno/vulkan/tu_shader.cc index b6db0cae05e..fcffe32ba4e 100644 --- a/src/freedreno/vulkan/tu_shader.cc +++ b/src/freedreno/vulkan/tu_shader.cc @@ -1867,7 +1867,6 @@ tu6_emit_fs_inputs(struct tu_cs *cs, const struct ir3_shader_variant *fs) CONDREG(smask_in_regid, A6XX_RB_PS_INPUT_CNTL_SAMPLEMASK) | CONDREG(samp_id_regid, A6XX_RB_PS_INPUT_CNTL_SAMPLEID) | CONDREG(ij_regid[IJ_PERSP_CENTER_RHW], A6XX_RB_PS_INPUT_CNTL_CENTERRHW) | - COND(fs->post_depth_coverage, A6XX_RB_PS_INPUT_CNTL_POSTDEPTHCOVERAGE) | COND(fs->frag_face, A6XX_RB_PS_INPUT_CNTL_FACENESS) | CONDREG(shading_rate_regid, A6XX_RB_PS_INPUT_CNTL_FOVEATION));