From 9faaff456139529cec4a7732d23575ded7e9bad8 Mon Sep 17 00:00:00 2001 From: Tatsuyuki Ishi Date: Thu, 16 Mar 2023 15:32:48 +0900 Subject: [PATCH] radv/rt: Don't upload the prolog twice. radv_shader_create already calls radv_shader_binary_upload. Fixes: 4b92a532859 ("radv: add radv_create_rt_prolog()") Part-of: --- src/amd/vulkan/radv_shader.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index 38267158cf3..631fc793707 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_shader.c @@ -2560,10 +2560,7 @@ radv_create_rt_prolog(struct radv_device *device) prolog = radv_shader_create(device, binary, device->keep_shader_info, false, &in_args); if (!prolog) - goto fail_create; - - if (!radv_shader_binary_upload(device, binary, prolog)) - goto fail_alloc; + goto fail; if (options.dump_shader) { fprintf(stderr, "Raytracing prolog"); @@ -2572,9 +2569,7 @@ radv_create_rt_prolog(struct radv_device *device) return prolog; -fail_alloc: - radv_shader_destroy(device, prolog); -fail_create: +fail: free(binary); return NULL; }